From 00d69a3f5f7521b67374fc852bad5ec970b42b7f Mon Sep 17 00:00:00 2001
From: Pierre Riteau <pierre@stackhpc.com>
Date: Thu, 10 Oct 2019 11:33:44 +0200
Subject: [PATCH] Remove ip kernel command line argument

The `ip` kernel command line argument is incompatible with newer dracut
versions used in CoreOS IPA images. A similar change was done in Ironic,
see https://review.opendev.org/#/c/566390/ for more details.

Change-Id: Ie70bba11c74b5769a7009f5b5599e41bd27e1d7c
Story: 2006700
Task: 37007
---
 .../templates/inspector-default-boot-ipxe.j2              | 2 +-
 .../ipxe-command-line-ip-argument-8b67a6a3601de1f3.yaml   | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)
 create mode 100644 releasenotes/notes/ipxe-command-line-ip-argument-8b67a6a3601de1f3.yaml

diff --git a/playbooks/roles/bifrost-ironic-install/templates/inspector-default-boot-ipxe.j2 b/playbooks/roles/bifrost-ironic-install/templates/inspector-default-boot-ipxe.j2
index 92e027002..f89610f4b 100644
--- a/playbooks/roles/bifrost-ironic-install/templates/inspector-default-boot-ipxe.j2
+++ b/playbooks/roles/bifrost-ironic-install/templates/inspector-default-boot-ipxe.j2
@@ -5,6 +5,6 @@ dhcp || reboot
 goto introspect
 
 :introspect
-kernel {{ ipa_kernel_url }} ipa-inspection-callback-url=http://{{ hostvars[inventory_hostname]['ansible_' + ans_network_interface ]['ipv4']['address'] }}:5050/v1/continue systemd.journald.forward_to_console=yes ip=${ip}:${next-server}:${gateway}:${netmask} BOOTIF=${mac} nofb nomodeset vga=normal console=ttyS0 {{ inspector_extra_kernel_options | default('') }} initrd={{ ipa_ramdisk_url | basename }}
+kernel {{ ipa_kernel_url }} ipa-inspection-callback-url=http://{{ hostvars[inventory_hostname]['ansible_' + ans_network_interface ]['ipv4']['address'] }}:5050/v1/continue systemd.journald.forward_to_console=yes BOOTIF=${mac} nofb nomodeset vga=normal console=ttyS0 {{ inspector_extra_kernel_options | default('') }} initrd={{ ipa_ramdisk_url | basename }}
 initrd {{ ipa_ramdisk_url }}
 boot
diff --git a/releasenotes/notes/ipxe-command-line-ip-argument-8b67a6a3601de1f3.yaml b/releasenotes/notes/ipxe-command-line-ip-argument-8b67a6a3601de1f3.yaml
new file mode 100644
index 000000000..27b914b16
--- /dev/null
+++ b/releasenotes/notes/ipxe-command-line-ip-argument-8b67a6a3601de1f3.yaml
@@ -0,0 +1,8 @@
+---
+fixes:
+  - |
+    The inspector iPXE template kernel command line argument ``ip`` has been
+    removed as it is incompatible with the ``BOOTIF`` and missing ``autoconf``
+    parameters with dracut. Without this change CoreOS IPA images cannot be
+    booted. Further details can be found in `story 2006700
+    <https://storyboard.openstack.org/#!/story/2006700>`_.