From 9c9712fb1187e9baee1d2cb01a48591088d563fa Mon Sep 17 00:00:00 2001 From: Pradeep Kumar Singh Date: Mon, 10 Aug 2015 10:41:22 +0900 Subject: [PATCH] Make tests in test_hrefs, test_quota py3 compatible 1. replace 'import urlparse' with 'from six.moves.urllib import parse'. 2. delete unused code in barbican/common/exception.py. Partially-Implements: blueprint barbican-py3 Change-Id: Ie8fdf31ec52e10ed54e0f4c7725ea35ab42bc435 --- barbican/common/exception.py | 7 ------- barbican/tests/utils.py | 4 ++-- tox.ini | 4 +++- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/barbican/common/exception.py b/barbican/common/exception.py index b7a3246b2..d7d2129c4 100644 --- a/barbican/common/exception.py +++ b/barbican/common/exception.py @@ -17,18 +17,11 @@ Barbican exception subclasses """ -import urlparse - from barbican import i18n as u _FATAL_EXCEPTION_FORMAT_ERRORS = False -class RedirectException(Exception): - def __init__(self, url): - self.url = urlparse.urlparse(url) - - class BarbicanException(Exception): """Base Barbican Exception diff --git a/barbican/tests/utils.py b/barbican/tests/utils.py index a114a0355..1ad5f9759 100644 --- a/barbican/tests/utils.py +++ b/barbican/tests/utils.py @@ -17,12 +17,12 @@ import functools from os import path import time import types -import urlparse import uuid import mock import oslotest.base as oslotest import six +from six.moves.urllib import parse import webtest from OpenSSL import crypto @@ -404,7 +404,7 @@ def create_timestamp_w_tz_and_offset(timezone=None, days=0, hours=0, minutes=0, def get_limit_and_offset_from_ref(ref): - matches = dict(urlparse.parse_qsl(urlparse.urlparse(ref).query)) + matches = dict(parse.parse_qsl(parse.urlparse(ref).query)) ref_limit = matches['limit'] ref_offset = matches['offset'] diff --git a/tox.ini b/tox.ini index a3369fd25..968d28193 100644 --- a/tox.ini +++ b/tox.ini @@ -27,7 +27,9 @@ deps = -r{toxinidir}/requirements.txt commands = python -m testtools.run \ - barbican.tests.common.test_utils + barbican.tests.common.test_utils \ + barbican.tests.common.test_hrefs \ + barbican.tests.common.test_quota [testenv:pep8] sitepackages = False