openstack/barbican
Code Issues Proposed changes

Fix consumer name length validator

Browse Source 
This patch fixes a mismatch between the size of the column for a
consumer "name" in the database and the value being checked by the api
validator.

The maximum size in the database is 36 chars [1], so we must use that value
in the validator.

[1] https://opendev.org/openstack/barbican/src/branch/stable/xena/barbican/model/models.py#L826

Story: 2009672
Task: 43939

Change-Id: I76f075a94056aa65cd44fd1d7f5d4b24109b6ed1
This commit is contained in:
Douglas Mendizábal 2021-11-10 15:19:07 -06:00
parent 6c841b23af
commit 31aa926175
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
barbican/common/validators.py
View File

@ -729,8 +729,8 @@ class ContainerConsumerValidator(ValidatorBase):
self.schema = { self.schema = {
"type": "object", "type": "object",
"properties": { "properties": {
"URL": {"type": "string", "minLength": 1}, "URL": {"type": "string", "maxLength": 255, "minLength": 1},
"name": {"type": "string", "maxLength": 255, "minLength": 1} "name": {"type": "string", "maxLength": 36, "minLength": 1}
}, },
"required": ["name", "URL"] "required": ["name", "URL"]
} }

5
releasenotes/notes/fix-story-2009672-d64ef6c10444f517.yaml Normal file
View File

@ -0,0 +1,5 @@
---
fixes:
- |
Fixed Story #2009672 - Fixed validator for Container Consumers to prevent
500 errors.