openstack/barbican
Code Issues Proposed changes

Merge "Raise maximum allowed secret size"

Browse Source
This commit is contained in:
Zuul 2021-04-29 14:47:08 +00:00 committed by Gerrit Code Review
commit 2e9d3ae6b8
4 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
barbican/common/config.py
View File

@ -29,8 +29,8 @@ from oslo_service import _options
from barbican import i18n as u from barbican import i18n as u
import barbican.version import barbican.version
MAX_BYTES_REQUEST_INPUT_ACCEPTED = 15000 MAX_BYTES_REQUEST_INPUT_ACCEPTED = 25000
DEFAULT_MAX_SECRET_BYTES = 10000 DEFAULT_MAX_SECRET_BYTES = 20000
KS_NOTIFICATIONS_GRP_NAME = 'keystone_notifications' KS_NOTIFICATIONS_GRP_NAME = 'keystone_notifications'
context_opts = [ context_opts = [

2
barbican/tests/api/controllers/test_secrets.py
View File

@ -628,7 +628,7 @@ class WhenGettingPuttingOrDeletingSecret(utils.BarbicanAPIBaseTestCase):
self.assertEqual(201, resp.status_int) self.assertEqual(201, resp.status_int)
text_too_big = 'x' * 10050 text_too_big = 'x' * 20050
put_resp = self.app.put( put_resp = self.app.put(
'/secrets/{0}'.format(secret_uuid), '/secrets/{0}'.format(secret_uuid),
text_too_big, text_too_big,

2
functionaltests/api/base.py
View File

@ -36,7 +36,7 @@ conf_multiple_backends_enabled = CONF.keymanager.\
class TestCase(oslotest.BaseTestCase): class TestCase(oslotest.BaseTestCase):
max_payload_size = 10000 max_payload_size = 20000
max_sized_payload = b'a' * max_payload_size max_sized_payload = b'a' * max_payload_size
oversized_payload = b'a' * (max_payload_size + 1) oversized_payload = b'a' * (max_payload_size + 1)
max_field_size = 255 max_field_size = 255

5
releasenotes/notes/increase-max-secret-size-da90164d8b328727.yaml Normal file
View File

@ -0,0 +1,5 @@
---
features:
- |
The default maximum secret size has been increased from 10 kB to 20 kb, and
the default maximum request size has been increased from 15 kB to 25 kB.