Remove use of Python builtin name for variables
'file' is a Python builtin name, and should not be used for a variable name. Fixes-Bug: #1763469 Change-Id: Ifb0a3fe51f995cee5d703be23ea444da3e837be6
This commit is contained in:
parent
e3d4507d10
commit
6ad31a4923
@ -87,22 +87,22 @@ class TestTitles(testtools.TestCase):
|
|||||||
|
|
||||||
|
|
||||||
def test_template(self):
|
def test_template(self):
|
||||||
files = glob.glob("guidelines/*")
|
filenames = glob.glob("guidelines/*")
|
||||||
for file in files:
|
for filename in filenames:
|
||||||
if file.endswith('~'):
|
if filename.endswith('~'):
|
||||||
continue
|
continue
|
||||||
if os.path.isdir(file):
|
if os.path.isdir(filename):
|
||||||
continue
|
continue
|
||||||
self.assertTrue(
|
self.assertTrue(
|
||||||
file.endswith(".rst") or file.endswith(".json"),
|
filename.endswith(".rst") or filename.endswith(".json"),
|
||||||
"guideline file must use 'rst' or 'json'"
|
"guideline file must use 'rst' or 'json'"
|
||||||
"extension: {file}".format(file=file))
|
"extension: {filename}".format(filename=filename))
|
||||||
with open(file) as f:
|
with open(filename) as f:
|
||||||
data = f.read()
|
data = f.read()
|
||||||
|
|
||||||
spec = docutils.core.publish_doctree(data)
|
spec = docutils.core.publish_doctree(data)
|
||||||
self._check_no_cr(file, data)
|
self._check_no_cr(filename, data)
|
||||||
self._check_trailing_spaces(file, data)
|
self._check_trailing_spaces(filename, data)
|
||||||
|
|
||||||
if file.endswith(".rst"):
|
if filename.endswith(".rst"):
|
||||||
self._check_lines_wrapping(file, data)
|
self._check_lines_wrapping(filename, data)
|
||||||
|
Loading…
x
Reference in New Issue
Block a user