From c8d8001a4f503eb36f7bdd819ed42d1153c6abf5 Mon Sep 17 00:00:00 2001
From: Stephen Finucane <stephenfin@redhat.com>
Date: Wed, 23 Mar 2022 10:25:00 +0000
Subject: [PATCH] Merge run-tests.sh, run-functional-tests.sh

These were always called in series. No point to maintain the separation.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: Ic100f380eea90115f0a44a82d1d28d5d216bed68
---
 run-functional-tests.sh | 20 --------------------
 run-tests.sh            | 25 ++++++++++++++++++++++++-
 tox.ini                 |  1 -
 3 files changed, 24 insertions(+), 22 deletions(-)
 delete mode 100755 run-functional-tests.sh

diff --git a/run-functional-tests.sh b/run-functional-tests.sh
deleted file mode 100755
index 4b92e9651..000000000
--- a/run-functional-tests.sh
+++ /dev/null
@@ -1,20 +0,0 @@
-#!/bin/bash -x
-set -e
-
-cleanup(){
-    type -t database_stop >/dev/null && database_stop || true
-}
-trap cleanup EXIT
-
-export OS_TEST_PATH=aodh/tests/functional_live
-export GABBI_LIVE_FAIL_IF_NO_TEST=1
-export AODH_SERVICE_TOKEN=foobar # Needed for gabbi
-export AODH_SERVICE_ROLES=admin
-
-AODH_TEST_DRIVERS=${AODH_TEST_DRIVERS:-postgresql}
-for indexer in ${AODH_TEST_DRIVERS}
-do
-    eval $(pifpaf -e DATABASE run $indexer)
-    pifpaf -e AODH run aodh --database-url $DATABASE_URL -- stestr run $*
-    cleanup
-done
diff --git a/run-tests.sh b/run-tests.sh
index e41258057..36e363f04 100755
--- a/run-tests.sh
+++ b/run-tests.sh
@@ -1,12 +1,35 @@
 #!/bin/bash -x
 set -e
 
+AODH_TEST_DRIVERS=${AODH_TEST_DRIVERS:-postgresql}
+export GABBI_LIVE_FAIL_IF_NO_TEST=1
+export AODH_SERVICE_TOKEN=foobar # Needed for gabbi
+export AODH_SERVICE_ROLES=admin
+
+# unit tests
+
 export OS_TEST_PATH=aodh/tests/unit
 stestr run $*
 
+# functional tests
+
 export OS_TEST_PATH=aodh/tests/functional
-AODH_TEST_DRIVERS=${AODH_TEST_DRIVERS:-postgresql}
 for indexer in ${AODH_TEST_DRIVERS}
 do
     pifpaf -g AODH_TEST_STORAGE_URL run $indexer -- stestr run $*
 done
+
+# live functional tests
+
+cleanup(){
+    type -t database_stop >/dev/null && database_stop || true
+}
+trap cleanup EXIT
+
+export OS_TEST_PATH=aodh/tests/functional_live
+for indexer in ${AODH_TEST_DRIVERS}
+do
+    eval $(pifpaf -e DATABASE run $indexer)
+    pifpaf -e AODH run aodh --database-url $DATABASE_URL -- stestr run $*
+    cleanup
+done
diff --git a/tox.ini b/tox.ini
index 0813e85d7..82d4620fa 100644
--- a/tox.ini
+++ b/tox.ini
@@ -25,7 +25,6 @@ deps =
 passenv = OS_TEST_TIMEOUT OS_STDOUT_CAPTURE OS_STDERR_CAPTURE OS_LOG_CAPTURE AODH_TEST_DRIVERS
 commands =
     {toxinidir}/run-tests.sh {posargs}
-    {toxinidir}/run-functional-tests.sh {posargs}
     aodh-config-generator
 allowlist_externals = bash