openstack/aodh
Code Issues Proposed changes

Remove low-value logging from publication codepath

Browse Source 
Previously, the pipeline publish codepath emitted log messages
with almost no diagnostic value other than a "comfort bump".
However the sheer volume of these message was overwhelming
logstash in the CI gate.

We remove the worst offenders from that codepath.

Change-Id: If630593e8f755ccc1ede16941459daac30d284ff
Closes-Bug: #1328596
This commit is contained in:
Eoghan Glynn 2014-06-10 17:07:32 +01:00
parent 32b64b79cb
commit 5f8a1fbf80
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ceilometer/pipeline.py
View File

@ -303,7 +303,6 @@ class Sink(object):
transformed_samples.append(sample) transformed_samples.append(sample)
if transformed_samples: if transformed_samples:
LOG.audit(_("Pipeline %s: Publishing samples"), self)
for p in self.publishers: for p in self.publishers:
try: try:
p.publish_samples(ctxt, transformed_samples) p.publish_samples(ctxt, transformed_samples)
@ -312,7 +311,6 @@ class Sink(object):
"Pipeline %(pipeline)s: Continue after error " "Pipeline %(pipeline)s: Continue after error "
"from publisher %(pub)s") % ({'pipeline': self, "from publisher %(pub)s") % ({'pipeline': self,
'pub': p})) 'pub': p}))
LOG.audit(_("Pipeline %s: Published samples") % self)
def publish_samples(self, ctxt, samples): def publish_samples(self, ctxt, samples):
for meter_name, samples in itertools.groupby( for meter_name, samples in itertools.groupby(

2
ceilometer/publisher/rpc.py
View File

@ -124,8 +124,6 @@ class RPCPublisher(publisher.PublisherBase):
] ]
topic = cfg.CONF.publisher_rpc.metering_topic topic = cfg.CONF.publisher_rpc.metering_topic
LOG.audit(_('Publishing %(m)d samples on %(t)s') % (
{'m': len(meters), 't': topic}))
self.local_queue.append((context, topic, meters)) self.local_queue.append((context, topic, meters))
if self.per_meter_topic: if self.per_meter_topic: