From 39e63a5a9c0b7f2b0c1db65022acfe48437ec654 Mon Sep 17 00:00:00 2001
From: Dmitriy Rabotyagov <dmitriy.rabotyagov@cleura.com>
Date: Mon, 17 Feb 2025 12:29:59 +0100
Subject: [PATCH] Auto-fix usage of modules via FQCN

Since ansible-core 2.10 it is recommended to use modules via FQCN
In order to align with recommendation, we perform migration
by applying suggestions made by `ansible-lint --fix=fqcn`

Change-Id: I1b52823d675a31559254b263e0f04c908306c73b
---
 handlers/main.yml                |  8 ++++----
 tasks/main.yml                   | 12 ++++++------
 tasks/zookeeper_install.yml      |  6 +++---
 tasks/zookeeper_post_install.yml |  6 +++---
 tasks/zookeeper_pre_install.yml  |  6 +++---
 5 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/handlers/main.yml b/handlers/main.yml
index d8c837b..eb020c1 100644
--- a/handlers/main.yml
+++ b/handlers/main.yml
@@ -14,14 +14,14 @@
 # under the License.
 
 - name: Regen pem # noqa: no-changed-when
-  shell: >-
+  ansible.builtin.shell: >-
     cat {{ zookeeper_ssl_cert }} $(test -f {{ zookeeper_ssl_ca_cert }} &&
       echo {{ zookeeper_ssl_ca_cert }}) {{ zookeeper_ssl_key }} > {{ zookeeper_ssl_keystore_location }}
   listen:
     - cert installed
 
 - name: Stop zookeeper
-  service:
+  ansible.builtin.service:
     name: "{{ zookeeper_service['name'] }}"
     state: "stopped"
   listen:
@@ -30,7 +30,7 @@
     - cert installed
 
 - name: Symlink zookeeper
-  file:
+  ansible.builtin.file:
     src: "/opt/zookeeper-{{ zookeeper_download_version }}"
     dest: /opt/zookeeper
     owner: "{{ zookeeper_system_user_name }}"
@@ -39,7 +39,7 @@
   register: symlink_zookeeper
 
 - name: Start zookeeper
-  service:
+  ansible.builtin.service:
     name: "{{ zookeeper_service['name'] }}"
     enabled: true
     state: "started"
diff --git a/tasks/main.yml b/tasks/main.yml
index 5b819b0..a5a5465 100644
--- a/tasks/main.yml
+++ b/tasks/main.yml
@@ -14,7 +14,7 @@
 # under the License.
 
 - name: Gather variables for each operating system
-  include_vars: "{{ lookup('first_found', params) }}"
+  ansible.builtin.include_vars: "{{ lookup('first_found', params) }}"
   vars:
     params:
       files:
@@ -29,22 +29,22 @@
     - always
 
 - name: Importing zookeeper_pre_install tasks
-  import_tasks: zookeeper_pre_install.yml
+  ansible.builtin.import_tasks: zookeeper_pre_install.yml
   tags:
     - zookeeper-install
 
 - name: Importing zookeeper_install tasks
-  import_tasks: zookeeper_install.yml
+  ansible.builtin.import_tasks: zookeeper_install.yml
   tags:
     - zookeeper-install
 
 - name: Importing zookeeper_post_install tasks
-  import_tasks: zookeeper_post_install.yml
+  ansible.builtin.import_tasks: zookeeper_post_install.yml
   tags:
     - zookeeper-config
 
 - name: Create and install SSL certificates
-  include_role:
+  ansible.builtin.include_role:
     name: pki
   vars:
     pki_setup_host: "{{ zookeeper_pki_setup_host }}"
@@ -61,7 +61,7 @@
     - zookeeper_ssl_client_enable or zookeeper_ssl_quorum_enable
 
 - name: Run the systemd service role
-  include_role:
+  ansible.builtin.include_role:
     name: systemd_service
   vars:
     systemd_user_name: "{{ zookeeper_system_user_name }}"
diff --git a/tasks/zookeeper_install.yml b/tasks/zookeeper_install.yml
index c7255e7..08d5683 100644
--- a/tasks/zookeeper_install.yml
+++ b/tasks/zookeeper_install.yml
@@ -14,7 +14,7 @@
 # under the License.
 
 - name: Install zookeeper requirements
-  package:
+  ansible.builtin.package:
     name: "{{ zookeeper_package_requirements }}"
     state: "{{ zookeeper_package_state }}"
   register: install_packages
@@ -24,7 +24,7 @@
   notify: Restart zookeeper
 
 - name: Download zookeeper binaries
-  get_url:
+  ansible.builtin.get_url:
     url: "{{ zookeeper_download_url }}"
     dest: "/opt/{{ zookeeper_download_url | basename }}"
     checksum: "{{ zookeeper_download_version_checksum }}"
@@ -32,7 +32,7 @@
   register: zookeeper_download
 
 - name: Unarchive downloaded zookeeper
-  unarchive:
+  ansible.builtin.unarchive:
     dest: "/opt/zookeeper-{{ zookeeper_download_version }}"
     src: "/opt/{{ zookeeper_download_url | basename }}"
     remote_src: true
diff --git a/tasks/zookeeper_post_install.yml b/tasks/zookeeper_post_install.yml
index f1bd8cb..1b4f04c 100644
--- a/tasks/zookeeper_post_install.yml
+++ b/tasks/zookeeper_post_install.yml
@@ -14,7 +14,7 @@
 # under the License.
 
 - name: Copy common zookeeper configuration
-  copy:
+  ansible.builtin.copy:
     src: "{{ item }}"
     dest: "{{ zookeeper_config_dir }}/{{ item | basename }}"
     remote_src: true
@@ -25,7 +25,7 @@
   notify: Restart zookeeper
 
 - name: Install zookeeper configuration
-  template:
+  ansible.builtin.template:
     dest: /etc/zookeeper/zoo.cfg
     group: "{{ zookeeper_system_group_name }}"
     mode: "{{ zookeeper_file_zoo_conf_mode }}"
@@ -34,7 +34,7 @@
   notify: Restart zookeeper
 
 - name: Setting cluster id
-  copy:
+  ansible.builtin.copy:
     dest: "{{ zookeeper_file_myid_dest }}"
     group: "{{ zookeeper_system_group_name }}"
     mode: "{{ zookeeper_file_zoo_conf_mode }}"
diff --git a/tasks/zookeeper_pre_install.yml b/tasks/zookeeper_pre_install.yml
index 9667676..4720c21 100644
--- a/tasks/zookeeper_pre_install.yml
+++ b/tasks/zookeeper_pre_install.yml
@@ -14,14 +14,14 @@
 # under the License.
 
 - name: Create the system group
-  group:
+  ansible.builtin.group:
     name: "{{ zookeeper_system_group_name }}"
     gid: "{{ zookeeper_system_group_gid | default(omit) }}"
     state: "present"
     system: "yes"
 
 - name: Create the zookeeper system user
-  user:
+  ansible.builtin.user:
     name: "{{ zookeeper_system_user_name }}"
     uid: "{{ zookeeper_system_user_name_uid | default(omit) }}"
     group: "{{ zookeeper_system_group_name }}"
@@ -32,7 +32,7 @@
     home: "{{ zookeeper_system_user_home }}"
 
 - name: Create required directories
-  file:
+  ansible.builtin.file:
     path: "{{ item }}"
     owner: "{{ zookeeper_system_user_name }}"
     group: "{{ zookeeper_system_group_name }}"