openstack/ansible-collections-openstack
Code Issues Proposed changes

Remove protocols choice in security rules

Browse Source 
Security group rule can support a lot of protocols now and their
integer representations in 0-255 range. Let's not limit for this
option anymore.

Change-Id: I0432e5d5d6d5f5ce935cf59a00f35153649c22dd
This commit is contained in:
Sagi Shnaidman 2021-01-15 19:34:30 +02:00 committed by Shnaidman Sagi
parent 049a2de725
commit a3f809eb99
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/modules/security_group_rule.py
View File

@ -19,8 +19,7 @@ options:
type: str type: str
protocol: protocol:
description: description:
- IP protocols ANY TCP UDP ICMP 112 (VRRP) 132 (SCTP) - IP protocols ANY TCP UDP ICMP and others, also number in range 0-255
choices: ['any', 'tcp', 'udp', 'icmp', '112', '132', None]
type: str type: str
port_range_min: port_range_min:
description: description:
@ -246,14 +245,11 @@ class SecurityGroupRuleModule(OpenStackModule):
argument_spec = dict( argument_spec = dict(
security_group=dict(required=True), security_group=dict(required=True),
# NOTE(Shrews): None is an acceptable protocol value for protocol=dict(type='str'),
# Neutron, but Nova will balk at this.
protocol=dict(default=None,
choices=[None, 'any', 'tcp', 'udp', 'icmp', '112', '132']),
port_range_min=dict(required=False, type='int'), port_range_min=dict(required=False, type='int'),
port_range_max=dict(required=False, type='int'), port_range_max=dict(required=False, type='int'),
remote_ip_prefix=dict(required=False, default=None), remote_ip_prefix=dict(required=False),
remote_group=dict(required=False, default=None), remote_group=dict(required=False),
ethertype=dict(default='IPv4', ethertype=dict(default='IPv4',
choices=['IPv4', 'IPv6']), choices=['IPv4', 'IPv6']),
direction=dict(default='ingress', direction=dict(default='ingress',