openstack/ansible-collections-openstack
Code Issues Proposed changes

Switch Recordset module to OpenStackModule

Browse Source 
Switch dns.recordset module to the general OpenStackModule.

Change-Id: I858880834acce6112eadd7e78e339f39b7c455da
This commit is contained in:
Artem Goncharov 2021-05-20 14:42:40 +02:00
parent 6b3bf3bba0
commit a32cff23c7
1 changed files with 85 additions and 86 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

171
plugins/modules/recordset.py
View File

@ -122,29 +122,11 @@ recordset:
sample: ['10.0.0.1'] sample: ['10.0.0.1']
''' '''
from ansible.module_utils.basic import AnsibleModule from ansible_collections.openstack.cloud.plugins.module_utils.openstack import OpenStackModule
from ansible_collections.openstack.cloud.plugins.module_utils.openstack import (openstack_full_argument_spec,
openstack_module_kwargs,
openstack_cloud_from_module)
def _system_state_change(state, records, description, ttl, recordset): class DnsRecordsetModule(OpenStackModule):
if state == 'present': argument_spec = dict(
if recordset is None:
return True
if records is not None and recordset['records'] != records:
return True
if description is not None and recordset['description'] != description:
return True
if ttl is not None and recordset['ttl'] != ttl:
return True
if state == 'absent' and recordset:
return True
return False
def main():
argument_spec = openstack_full_argument_spec(
zone=dict(required=True), zone=dict(required=True),
name=dict(required=True), name=dict(required=True),
recordset_type=dict(required=False, choices=['a', 'aaaa', 'mx', 'cname', 'txt', 'ns', 'srv', 'ptr', 'caa']), recordset_type=dict(required=False, choices=['a', 'aaaa', 'mx', 'cname', 'txt', 'ns', 'srv', 'ptr', 'caa']),
@ -154,85 +136,102 @@ def main():
state=dict(default='present', choices=['absent', 'present']), state=dict(default='present', choices=['absent', 'present']),
) )
module_kwargs = openstack_module_kwargs() module_kwargs = dict(
module = AnsibleModule(argument_spec, required_if=[
required_if=[ ('state', 'present',
('state', 'present', ['recordset_type', 'records'])],
['recordset_type', 'records'])], supports_check_mode=True
supports_check_mode=True, )
**module_kwargs)
module.module_min_sdk_version = '0.28.0' module_min_sdk_version = '0.28.0'
zone = module.params.get('zone')
name = module.params.get('name')
state = module.params.get('state')
sdk, cloud = openstack_cloud_from_module(module) def _system_state_change(self, state, records, description, ttl, recordset):
recordsets = cloud.search_recordsets(zone, name_or_id=name) if state == 'present':
if recordset is None:
return True
if records is not None and recordset['records'] != records:
return True
if description is not None and recordset['description'] != description:
return True
if ttl is not None and recordset['ttl'] != ttl:
return True
if state == 'absent' and recordset:
return True
return False
if recordsets: def run(self):
recordset = recordsets[0] zone = self.params.get('zone')
try: name = self.params.get('name')
recordset_id = recordset['id'] state = self.params.get('state')
except KeyError as e:
module.fail_json(msg=str(e))
else:
# recordsets is filtered by type and should never be more than 1 return
recordset = None
if state == 'present': recordsets = self.conn.search_recordsets(zone, name_or_id=name)
recordset_type = module.params.get('recordset_type').upper()
records = module.params.get('records')
description = module.params.get('description')
ttl = module.params.get('ttl')
kwargs = {} if recordsets:
if description: recordset = recordsets[0]
kwargs['description'] = description try:
kwargs['records'] = records recordset_id = recordset['id']
except KeyError as e:
self.fail_json(msg=str(e))
else:
# recordsets is filtered by type and should never be more than 1 return
recordset = None
if module.check_mode: if state == 'present':
module.exit_json(changed=_system_state_change(state, recordset_type = self.params.get('recordset_type').upper()
records, description, records = self.params.get('records')
ttl, recordset)) description = self.params.get('description')
ttl = self.params.get('ttl')
if recordset is None: kwargs = {}
if ttl: if description:
kwargs['ttl'] = ttl kwargs['description'] = description
kwargs['records'] = records
if self.ansible.check_mode:
self.exit_json(
changed=self._system_state_change(
state, records, description, ttl, recordset))
if recordset is None:
if ttl:
kwargs['ttl'] = ttl
else:
kwargs['ttl'] = 300
recordset = self.conn.create_recordset(
zone=zone, name=name, recordset_type=recordset_type,
**kwargs)
changed = True
else: else:
kwargs['ttl'] = 300
recordset = cloud.create_recordset( if ttl:
zone=zone, name=name, recordset_type=recordset_type, kwargs['ttl'] = ttl
**kwargs)
changed = True
else:
if ttl: pre_update_recordset = recordset
kwargs['ttl'] = ttl changed = self._system_state_change(
state, records, description, ttl, pre_update_recordset)
if changed:
recordset = self.conn.update_recordset(
zone=zone, name_or_id=recordset_id, **kwargs)
pre_update_recordset = recordset self.exit_json(changed=changed, recordset=recordset)
changed = _system_state_change(state, records,
description, ttl,
pre_update_recordset)
if changed:
recordset = cloud.update_recordset(
zone=zone, name_or_id=recordset_id, **kwargs)
module.exit_json(changed=changed, recordset=recordset) elif state == 'absent':
if self.ansible.check_mode:
self.exit_json(changed=self._system_state_change(
state, None, None, None, recordset))
elif state == 'absent': if recordset is None:
if module.check_mode: changed = False
module.exit_json(changed=_system_state_change(state, else:
None, None, self.conn.delete_recordset(zone, recordset_id)
None, recordset)) changed = True
self.exit_json(changed=changed)
if recordset is None:
changed = False def main():
else: module = DnsRecordsetModule()
cloud.delete_recordset(zone, recordset_id) module()
changed = True
module.exit_json(changed=changed)
if __name__ == '__main__': if __name__ == '__main__':