From 49c95804bac15018df575ef5b3ea572caba22835 Mon Sep 17 00:00:00 2001
From: frenzy_friday <anbanerj@redhat.com>
Date: Tue, 8 Dec 2020 17:04:54 +0200
Subject: [PATCH] Add network tests for versioned args

1. Updated Create network tasks with mtu and port security enabled params which are supported for sdk version >= 0.18
2. Added task to assert that network creation with new params fail if sdk version is lower than 0.18

Change-Id: I7d65d8553e820344f76cf1092e0a373c8100b7c8
---
 ci/roles/network/defaults/main.yml |  4 ++
 ci/roles/network/tasks/main.yml    | 64 ++++++++++++++++++++++++++----
 2 files changed, 60 insertions(+), 8 deletions(-)

diff --git a/ci/roles/network/defaults/main.yml b/ci/roles/network/defaults/main.yml
index d5435ecb..095f17fa 100644
--- a/ci/roles/network/defaults/main.yml
+++ b/ci/roles/network/defaults/main.yml
@@ -1,3 +1,7 @@
 network_name: shade_network
+network_name_newparams: newparams_network
 network_shared: false
 network_external: false
+dns_domain: example.opendev.org
+mtu: 1350
+port_security_enabled: false
diff --git a/ci/roles/network/tasks/main.yml b/ci/roles/network/tasks/main.yml
index 75540862..f770d186 100644
--- a/ci/roles/network/tasks/main.yml
+++ b/ci/roles/network/tasks/main.yml
@@ -1,5 +1,5 @@
 ---
-- name: Create network
+- name: Create network - generic
   openstack.cloud.network:
      cloud: "{{ cloud }}"
      name: "{{ network_name }}"
@@ -7,7 +7,7 @@
      shared: "{{ network_shared }}"
      external: "{{ network_external }}"
 
-- name: Gather networks info
+- name: Gather networks info - generic
   openstack.cloud.networks_info:
      cloud: "{{ cloud }}"
      name: "{{ network_name }}"
@@ -15,15 +15,63 @@
        shared: "{{ network_shared|string|capitalize }}"
   register: result
 
-- name: Verify networks info
+- name: Verify networks info - generic
   assert:
     that:
-      - "result.openstack_networks.0.name ==  network_name"
-      - "(result.openstack_networks.0.shared|lower) == (network_shared|lower)"
-      - "result.openstack_networks[0]['router:external'] == {{ network_external }}"
+      - result.openstack_networks.0.name == network_name
+      - (result.openstack_networks.0.shared|lower) == (network_shared|lower)
+      - result.openstack_networks[0]['router:external'] == {{ network_external }}
 
-- name: Delete network
+- name: Create network - with new SDK params
   openstack.cloud.network:
      cloud: "{{ cloud }}"
-     name: "{{ network_name }}"
+     name: "{{ network_name_newparams }}"
+     state: present
+     shared: "{{ network_shared }}"
+     external: "{{ network_external }}"
+     mtu: "{{ mtu }}"
+     port_security_enabled: "{{ port_security_enabled }}"
+  register: result_create_nw_with_new_params
+  ignore_errors: yes
+
+- name: Check errors below min sdk version - with new SDK params
+  assert:
+    that:
+      - result_create_nw_with_new_params.failed
+      - '"the installed version of the openstacksdk library MUST be >=0.18.0." in result_create_nw_with_new_params.msg'
+  when: sdk_version is version('0.18', '<')
+
+- name: Gather networks info - with new SDK params
+  openstack.cloud.networks_info:
+     cloud: "{{ cloud }}"
+     name: "{{ network_name_newparams }}"
+  register: result_newparams
+  when: sdk_version is version('0.18', '>=')
+
+- name: Verify networks info - with new SDK params
+  assert:
+    that:
+      - result_newparams.openstack_networks.0.name == network_name_newparams
+      - result_newparams.openstack_networks.0.mtu == mtu
+      - result_newparams.openstack_networks.0.port_security_enabled == port_security_enabled
+  when: sdk_version is version('0.18', '>=')
+
+- name: Delete network - generic and with new SDK params
+  openstack.cloud.network:
+     cloud: "{{ cloud }}"
+     name: "{{ item }}"
      state: absent
+  with_items:
+      - "{{ network_name }}"
+      - "{{ network_name_newparams }}"
+
+- name: Gather networks info - deleted
+  openstack.cloud.networks_info:
+     cloud: "{{ cloud }}"
+     name: "{{ network_name }}"
+  register: result_nonet
+
+- name: Verify networks info - deleted
+  assert:
+    that:
+      - result_nonet.openstack_networks == []