openstack/ansible-collections-openstack
Code Issues Proposed changes

Switch lb_member module to OpenStackModule

Browse Source 
Switch loadbalancer member module to the general OpenStackModule.

Change-Id: I92d09c27205f8fa01df9ddab96448c433c42ef79
This commit is contained in:
Artem Goncharov 2021-05-20 15:45:11 +02:00 committed by Artem Goncharov
parent 6b3bf3bba0
commit 5217b6bdc4
1 changed files with 59 additions and 63 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

122
plugins/modules/lb_member.py
View File

@ -130,42 +130,11 @@ EXAMPLES = '''
import time import time
from ansible.module_utils.basic import AnsibleModule from ansible_collections.openstack.cloud.plugins.module_utils.openstack import OpenStackModule
from ansible_collections.openstack.cloud.plugins.module_utils.openstack import (openstack_full_argument_spec,
openstack_module_kwargs,
openstack_cloud_from_module)
def _wait_for_member_status(module, cloud, pool_id, member_id, status, class LoadbalancerMemberModule(OpenStackModule):
failures, interval=5): argument_spec = dict(
timeout = module.params['timeout']
total_sleep = 0
if failures is None:
failures = []
while total_sleep < timeout:
member = cloud.load_balancer.get_member(member_id, pool_id)
provisioning_status = member.provisioning_status
if provisioning_status == status:
return member
if provisioning_status in failures:
module.fail_json(
msg="Member %s transitioned to failure state %s" %
(member_id, provisioning_status)
)
time.sleep(interval)
total_sleep += interval
module.fail_json(
msg="Timeout waiting for member %s to transition to %s" %
(member_id, status)
)
def main():
argument_spec = openstack_full_argument_spec(
name=dict(required=True), name=dict(required=True),
state=dict(default='present', choices=['absent', 'present']), state=dict(default='present', choices=['absent', 'present']),
pool=dict(required=True), pool=dict(required=True),
@ -173,54 +142,81 @@ def main():
protocol_port=dict(default=80, type='int'), protocol_port=dict(default=80, type='int'),
subnet_id=dict(default=None), subnet_id=dict(default=None),
) )
module_kwargs = openstack_module_kwargs() module_kwargs = dict()
module = AnsibleModule(argument_spec, **module_kwargs)
sdk, cloud = openstack_cloud_from_module(module) def _wait_for_member_status(self, pool_id, member_id, status,
name = module.params['name'] failures, interval=5):
pool = module.params['pool'] timeout = self.params['timeout']
total_sleep = 0
if failures is None:
failures = []
while total_sleep < timeout:
member = self.conn.load_balancer.get_member(member_id, pool_id)
provisioning_status = member.provisioning_status
if provisioning_status == status:
return member
if provisioning_status in failures:
self.fail_json(
msg="Member %s transitioned to failure state %s" %
(member_id, provisioning_status)
)
time.sleep(interval)
total_sleep += interval
self.fail_json(
msg="Timeout waiting for member %s to transition to %s" %
(member_id, status)
)
def run(self):
name = self.params['name']
pool = self.params['pool']
try:
changed = False changed = False
pool_ret = cloud.load_balancer.find_pool(name_or_id=pool) pool_ret = self.conn.load_balancer.find_pool(name_or_id=pool)
if not pool_ret: if not pool_ret:
module.fail_json(msg='pool %s is not found' % pool) self.fail_json(msg='pool %s is not found' % pool)
pool_id = pool_ret.id pool_id = pool_ret.id
member = cloud.load_balancer.find_member(name, pool_id) member = self.conn.load_balancer.find_member(name, pool_id)
if module.params['state'] == 'present': if self.params['state'] == 'present':
if not member: if not member:
member = cloud.load_balancer.create_member( member = self.conn.load_balancer.create_member(
pool_ret, pool_ret,
address=module.params['address'], address=self.params['address'],
name=name, name=name,
protocol_port=module.params['protocol_port'], protocol_port=self.params['protocol_port'],
subnet_id=module.params['subnet_id'] subnet_id=self.params['subnet_id']
) )
changed = True changed = True
if not module.params['wait']: if not self.params['wait']:
module.exit_json(changed=changed, self.exit_json(
member=member.to_dict(), changed=changed, member=member.to_dict(), id=member.id)
id=member.id)
if module.params['wait']: if self.params['wait']:
member = _wait_for_member_status(module, cloud, pool_id, member = self._wait_for_member_status(
member.id, "ACTIVE", pool_id, member.id, "ACTIVE", ["ERROR"])
["ERROR"])
module.exit_json(changed=changed, member=member.to_dict(), self.exit_json(
id=member.id) changed=changed, member=member.to_dict(), id=member.id)
elif module.params['state'] == 'absent': elif self.params['state'] == 'absent':
if member: if member:
cloud.load_balancer.delete_member(member, pool_ret) self.conn.load_balancer.delete_member(member, pool_ret)
changed = True changed = True
module.exit_json(changed=changed) self.exit_json(changed=changed)
except sdk.exceptions.OpenStackCloudException as e:
module.fail_json(msg=str(e), extra_data=e.extra_data)
def main():
module = LoadbalancerMemberModule()
module()
if __name__ == "__main__": if __name__ == "__main__":