From 51f1fea8b3379701eec769d9f36c0d4e7db133fd Mon Sep 17 00:00:00 2001
From: Robin Koch <robin.koch@bertelsmann.de>
Date: Thu, 5 May 2022 14:49:54 +0200
Subject: [PATCH] Added tests for router interface creation in a shared network

Story: 2010012

Change-Id: Ifa6a7e5a799a5bdfb3bbf585436e57cc6eea0811
---
 ci/roles/router/tasks/main.yml           |   2 +
 ci/roles/router/tasks/shared_network.yml | 127 +++++++++++++++++++++++
 plugins/modules/routers_info.py          |   2 +-
 3 files changed, 130 insertions(+), 1 deletion(-)
 create mode 100644 ci/roles/router/tasks/shared_network.yml

diff --git a/ci/roles/router/tasks/main.yml b/ci/roles/router/tasks/main.yml
index afbe654f..6d51e7ea 100644
--- a/ci/roles/router/tasks/main.yml
+++ b/ci/roles/router/tasks/main.yml
@@ -750,3 +750,5 @@
      name: "{{ external_network_name }}"
   when:
     - network_external
+
+- include_tasks: shared_network.yml
diff --git a/ci/roles/router/tasks/shared_network.yml b/ci/roles/router/tasks/shared_network.yml
new file mode 100644
index 00000000..cc5bd128
--- /dev/null
+++ b/ci/roles/router/tasks/shared_network.yml
@@ -0,0 +1,127 @@
+---
+- name: Create the first project
+  openstack.cloud.project:
+    cloud: "{{ cloud }}"
+    state: present
+    name: "shared_net_test_1"
+    description: "Project that contains the subnet to be shared"
+    domain_id: default
+    enabled: True
+  register: project_1
+
+- name: Create the network to be shared
+  openstack.cloud.network:
+    cloud: "{{ cloud }}"
+    state: present
+    name: "my_shared_network"
+    project: "shared_net_test_1"
+    external: False
+    provider_network_type: vxlan
+  register: shared_network
+
+- name: Create ipv4 subnet
+  openstack.cloud.subnet:
+    cloud: "{{ cloud }}"
+    state: present
+    network_name: "{{ shared_network.id }}"
+    name: "my_shared_subnet"
+    project: "shared_net_test_1"
+    ip_version: "4"
+    cidr: "10.0.0.0/24"
+    gateway_ip: "10.0.0.1"
+  register: shared_subnet
+
+- name: Create the second project
+  openstack.cloud.project:
+    cloud: "{{ cloud }}"
+    state: present
+    name: "shared_net_test_2"
+    description: "Project that contains the subnet to be shared"
+    domain_id: default
+    enabled: True
+  register: project_2
+
+- name: Share the network with the second project
+  openstack.cloud.neutron_rbac_policy:
+    cloud: "{{ cloud }}"
+    action: 'access_as_shared'
+    object_id: "{{ shared_network.id }}"
+    object_type: 'network'
+    target_project_id: "{{ project_2.project.id }}"
+    project_id: "{{ project_1.project.id }}"
+  register: rbac_rule
+
+- name: Create router with interface in shared network
+  openstack.cloud.router:
+    cloud: "{{ cloud }}"
+    state: present
+    name: "shared_net_test2_router"
+    project: "shared_net_test_2"
+    interfaces:
+      - net: "{{ shared_network.id }}"
+        portip: "10.0.0.42"
+        subnet: "{{ shared_subnet.id }}"
+  register: router
+
+- name: Gather routers info
+  openstack.cloud.routers_info:
+     cloud: "{{ cloud }}"
+     name: "shared_net_test2_router"
+  register: routers
+
+- name: List ports of first router
+  openstack.cloud.port_info:
+    cloud: "{{ cloud }}"
+    filters:
+      device_id: "{{ routers.routers.0.id }}"
+  register: ports
+
+- name: Verify routers info
+  assert:
+    that:
+      - routers.routers.0.id == router.router.id
+      - ports.ports
+        |rejectattr('device_owner', 'equalto', 'network:router_gateway')
+        |sum(attribute='fixed_ips', start=[])
+        |map(attribute='ip_address')
+        |sort|list == ["10.0.0.42"]
+
+- name: delete router
+  openstack.cloud.router:
+    cloud: "{{ cloud }}"
+    state: absent
+    name: "shared_net_test2_router"
+    project: "shared_net_test_2"
+
+- name: delete rbac rule
+  openstack.cloud.neutron_rbac_policy:
+    cloud: "{{ cloud }}"
+    policy_id: "{{ rbac_rule.policy.id }}"
+    state: absent
+
+- name: delete subnet
+  openstack.cloud.subnet:
+    cloud: "{{ cloud }}"
+    state: absent
+    network_name: "{{ shared_network.id }}"
+    name: "my_shared_subnet"
+    project: "shared_net_test_1"
+
+- name: delete network
+  openstack.cloud.network:
+    cloud: "{{ cloud }}"
+    state: absent
+    name: "my_shared_network"
+    project: "shared_net_test_1"
+
+- name: delete project 2
+  openstack.cloud.project:
+    cloud: "{{ cloud }}"
+    state: absent
+    name: "shared_net_test_2"
+
+- name: delete project 1
+  openstack.cloud.project:
+    cloud: "{{ cloud }}"
+    state: absent
+    name: "shared_net_test_1"
diff --git a/plugins/modules/routers_info.py b/plugins/modules/routers_info.py
index a83fc7c4..44f88a5f 100644
--- a/plugins/modules/routers_info.py
+++ b/plugins/modules/routers_info.py
@@ -115,7 +115,7 @@ EXAMPLES = '''
   openstack.cloud.port_info:
     cloud: devstack
     filters:
-      device_id: "{{ routers[0].router.id }}"
+      device_id: "{{ routers.routers.0.id }}"
   register: ports
 
 - name: Show first router's fixed ips