openinfra/openstackid-resources
Code Issues Proposed changes

Allows null on file param on location image/map update method

Browse Source 
Change-Id: I20ccb2a860c8ab2b71c612f8c08d818385ec4e29
This commit is contained in:
Sebastian Marcet 2018-03-14 20:30:24 -03:00
parent 00edd5a7e3
commit df61dabc05
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/Services/Model/ILocationService.php
View File

@ -163,12 +163,12 @@ interface ILocationService
* @param int $location_id * @param int $location_id
* @param int $map_id * @param int $map_id
* @param array $metadata * @param array $metadata
* @param $file * @param UploadedFile|null $file
* @return SummitLocationImage * @return SummitLocationImage
* @throws EntityNotFoundException * @throws EntityNotFoundException
* @throws ValidationException * @throws ValidationException
*/ */
public function updateLocationMap(Summit $summit, $location_id, $map_id, array $metadata, UploadedFile $file); public function updateLocationMap(Summit $summit, $location_id, $map_id, array $metadata, UploadedFile $file = null);
/** /**
* @param Summit $summit * @param Summit $summit
@ -196,12 +196,12 @@ interface ILocationService
* @param int $location_id * @param int $location_id
* @param int $image_id * @param int $image_id
* @param array $metadata * @param array $metadata
* @param $file * @param UploadedFile|null $file
* @return SummitLocationImage * @return SummitLocationImage
* @throws EntityNotFoundException * @throws EntityNotFoundException
* @throws ValidationException * @throws ValidationException
*/ */
public function updateLocationImage(Summit $summit, $location_id, $image_id, array $metadata, UploadedFile $file); public function updateLocationImage(Summit $summit, $location_id, $image_id, array $metadata, UploadedFile $file = null);
/** /**
* @param Summit $summit * @param Summit $summit

8
app/Services/Model/LocationService.php
View File

@ -1204,12 +1204,12 @@ final class LocationService implements ILocationService
* @param int $location_id * @param int $location_id
* @param int $map_id * @param int $map_id
* @param array $metadata * @param array $metadata
* @param $file * @param UploadedFile|null $file
* @return SummitLocationImage * @return SummitLocationImage
* @throws EntityNotFoundException * @throws EntityNotFoundException
* @throws ValidationException * @throws ValidationException
*/ */
public function updateLocationMap(Summit $summit, $location_id, $map_id, array $metadata, UploadedFile $file) public function updateLocationMap(Summit $summit, $location_id, $map_id, array $metadata, UploadedFile $file = null)
{ {
return $this->tx_service->transaction(function () use ($summit, $location_id, $map_id, $metadata, $file) { return $this->tx_service->transaction(function () use ($summit, $location_id, $map_id, $metadata, $file) {
$max_file_size = config('file_upload.max_file_upload_size') ; $max_file_size = config('file_upload.max_file_upload_size') ;
@ -1475,12 +1475,12 @@ final class LocationService implements ILocationService
* @param int $location_id * @param int $location_id
* @param int $image_id * @param int $image_id
* @param array $metadata * @param array $metadata
* @param $file * @param UploadedFile|null $file
* @return SummitLocationImage * @return SummitLocationImage
* @throws EntityNotFoundException * @throws EntityNotFoundException
* @throws ValidationException * @throws ValidationException
*/ */
public function updateLocationImage(Summit $summit, $location_id, $image_id, array $metadata, UploadedFile $file) public function updateLocationImage(Summit $summit, $location_id, $image_id, array $metadata, UploadedFile $file = null)
{ {
return $this->tx_service->transaction(function () use ($summit, $location_id, $image_id, $metadata, $file) { return $this->tx_service->transaction(function () use ($summit, $location_id, $image_id, $metadata, $file) {
$max_file_size = config('file_upload.max_file_upload_size') ; $max_file_size = config('file_upload.max_file_upload_size') ;