opendev/system-config
Code Issues Proposed changes

Add +1/-1 votes for pre-approval checks.

Browse Source 
A pre-approval check is a vote of confidence, not a final verification,
so we should be voting +1/-1 on those, instead of +2/-2.

Change-Id: I916b6ae3d459e1fe1ada988d77a8bedae4a59db8
This commit is contained in:
Monty Taylor 2012-05-03 22:01:42 -07:00
parent 3b36aa154a
commit d9c58f56a6
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
modules/jenkins_jobs/templates/trigger_gerrit_uploaded_merge.xml.erb
View File

@ -14,6 +14,14 @@
</com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject> </com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject>
<% end %> <% end %>
</gerritProjects> </gerritProjects>
<gerritBuildStartedVerifiedValue>0</gerritBuildStartedVerifiedValue>
<gerritBuildStartedCodeReviewValue>0</gerritBuildStartedCodeReviewValue>
<gerritBuildSuccessfulVerifiedValue>1</gerritBuildSuccessfulVerifiedValue>
<gerritBuildSuccessfulCodeReviewValue>0</gerritBuildSuccessfulCodeReviewValue>
<gerritBuildFailedVerifiedValue>-1</gerritBuildFailedVerifiedValue>
<gerritBuildFailedCodeReviewValue>0</gerritBuildFailedCodeReviewValue>
<gerritBuildUnstableVerifiedValue>0</gerritBuildUnstableVerifiedValue>
<gerritBuildUnstableCodeReviewValue>-1</gerritBuildUnstableCodeReviewValue>
<silentMode>false</silentMode> <silentMode>false</silentMode>
<escapeQuotes>true</escapeQuotes> <escapeQuotes>true</escapeQuotes>
<triggerOnPatchsetUploadedEvent>true</triggerOnPatchsetUploadedEvent> <triggerOnPatchsetUploadedEvent>true</triggerOnPatchsetUploadedEvent>

8
modules/jenkins_jobs/templates/trigger_gerrit_uploaded_plain.xml.erb
View File

@ -14,6 +14,14 @@
</com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject> </com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject>
<% end %> <% end %>
</gerritProjects> </gerritProjects>
<gerritBuildStartedVerifiedValue>0</gerritBuildStartedVerifiedValue>
<gerritBuildStartedCodeReviewValue>0</gerritBuildStartedCodeReviewValue>
<gerritBuildSuccessfulVerifiedValue>1</gerritBuildSuccessfulVerifiedValue>
<gerritBuildSuccessfulCodeReviewValue>0</gerritBuildSuccessfulCodeReviewValue>
<gerritBuildFailedVerifiedValue>-1</gerritBuildFailedVerifiedValue>
<gerritBuildFailedCodeReviewValue>0</gerritBuildFailedCodeReviewValue>
<gerritBuildUnstableVerifiedValue>0</gerritBuildUnstableVerifiedValue>
<gerritBuildUnstableCodeReviewValue>-1</gerritBuildUnstableCodeReviewValue>
<silentMode>false</silentMode> <silentMode>false</silentMode>
<escapeQuotes>true</escapeQuotes> <escapeQuotes>true</escapeQuotes>
<triggerOnPatchsetUploadedEvent>true</triggerOnPatchsetUploadedEvent> <triggerOnPatchsetUploadedEvent>true</triggerOnPatchsetUploadedEvent>