opendev/storyboard
Code Issues Proposed changes

Fixes the Python 3 dependencies and iterator

Browse Source 
A. Fixes depedencies of Python 3:

Following the documentation about Python 3 requirements.
It was needed to change in the file ./requirements.txt
replacing "python-openid" with "python3-openid".

B. Fixing Python 3 compatibility in the migration script:

In order to fix the migration script to run on Python 3
I changed the line #24 on ./migrate/launchpad/reader.py,
changing the iterator.

Also, I added  in the file "./requirements.txt" a comment
to use the library "launchpadlib" in order to run
the migrate script.

Change-Id: Iedcd283ade1ea62fdc5777dfe7b1ae5916db3480
This commit is contained in:
Camila Moura 2019-02-27 14:40:40 +01:00
parent 747444deb1
commit d082d8ac0f
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
requirements.txt
View File

@ -11,7 +11,7 @@ pecan>=0.4.5
oslo.db>=4.27.0 # Apache-2.0 oslo.db>=4.27.0 # Apache-2.0
oslo.log>=1.0.0 oslo.log>=1.0.0
pika>=0.9.14 pika>=0.9.14
python-openid python3-openid
PyYAML>=3.1.0 PyYAML>=3.1.0
requests>=1.1 requests>=1.1
six>=1.7.0 six>=1.7.0
@ -28,3 +28,4 @@ apscheduler>=3.0.1,<3.1.0
python_dateutil>=2.4.0 python_dateutil>=2.4.0
oslo.concurrency>=3.8.0 # Apache-2.0 oslo.concurrency>=3.8.0 # Apache-2.0
oslo.i18n>=2.1.0 # Apache-2.0 oslo.i18n>=2.1.0 # Apache-2.0
#launchpadlib # Only for migration

2
storyboard/migrate/launchpad/reader.py
View File

@ -39,4 +39,4 @@ class LaunchpadReader(object):
return self.next() return self.next()
def next(self): def next(self):
return self.task_iterator.next() return next(self.task_iterator)