From 1602564e687b91d664c1a5eacf06c3771eff004f Mon Sep 17 00:00:00 2001 From: Tom Fifield Date: Mon, 29 Jul 2013 09:19:58 -0700 Subject: [PATCH] cease docimpact emails, create bugs only We've been running the DocImpact bug generation code for several weeks now and are happy with the results. We'd now like to cease the emails and only generate bugs from DocImpact strings. This patch updates the logic to never send an email for DocImpact, and changes the docstring to reflect this. This change should not affect any other types of impacts. patchset2 fixes PEP8 issue Change-Id: I5c46f0d540949bc4a5de1e57fcd68c537a54ca15 --- jeepyb/cmd/notify_impact.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/jeepyb/cmd/notify_impact.py b/jeepyb/cmd/notify_impact.py index 55e44c8..93f2e10 100644 --- a/jeepyb/cmd/notify_impact.py +++ b/jeepyb/cmd/notify_impact.py @@ -80,14 +80,12 @@ def process_impact(git_log, args): """Process DocImpact flag. If the 'DocImpact' flag is present, create a new documentation bug in - the openstack-manuals launchpad project based on the git_log, then - (and for non-documentation impacts) notify the mailing list of impact, - unless a bug was created. + the openstack-manuals launchpad project based on the git_log. + For non-documentation impacts notify the mailing list of impact. """ if args.impact.lower() == 'docimpact': - buglink = create_bug(git_log, args, 'openstack-manuals') - if buglink is not None: - return + create_bug(git_log, args, 'openstack-manuals') + return email_content = EMAIL_TEMPLATE % (args.impact, args.change_url, git_log)