From 1faf327cfbb1a3ee21a77a3d2068e11a7e9b7530 Mon Sep 17 00:00:00 2001 From: Tom Fifield Date: Fri, 14 Jun 2013 14:40:46 +1000 Subject: [PATCH] Fix docimpact bug generation code My sincere apologies to the infra team. The original code to create bugs from DocImpact itself suffered from a bug - it was trying to refer to an email address rather than an impact line. Luckily, due to the design, this had no impact on sending Impact emails for security or docs. This change correctly checks for docimpact prior to bug creation. Change-Id: I1b8e037cab0a0424c765706f4a7b690ba5bd96d0 Reviewed-on: https://review.openstack.org/32994 Reviewed-by: Diane Fleming Reviewed-by: Clark Boylan Reviewed-by: Khai Do Approved: James E. Blair Reviewed-by: James E. Blair Tested-by: Jenkins --- jeepyb/cmd/notify_impact.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jeepyb/cmd/notify_impact.py b/jeepyb/cmd/notify_impact.py index 6abcdfa..4dc92e5 100644 --- a/jeepyb/cmd/notify_impact.py +++ b/jeepyb/cmd/notify_impact.py @@ -60,7 +60,7 @@ def process_impact(git_log, args): the openstack-manuals launchpad project based on the git_log, then (and for non-documentation impacts) notify the mailing list of impact """ - if args.dest_address.lower == 'docimpact': + if args.impact.lower() == 'docimpact': launchpad = Launchpad.login_with('Gerrit User Sync', LPNET_SERVICE_ROOT, GERRIT_CACHE_DIR,