opendev/pypi-mirror
Code Issues Proposed changes

Fix docimpact bug generation code

Browse Source 
My sincere apologies to the infra team.

The original code to create bugs from DocImpact itself suffered
from a bug - it was trying to refer to an email address rather than
an impact line. Luckily, due to the design, this had no impact on
 sending Impact emails for security or docs.

This change correctly checks for docimpact prior to bug creation.

Change-Id: I1b8e037cab0a0424c765706f4a7b690ba5bd96d0
Reviewed-on: https://review.openstack.org/32994
Reviewed-by: Diane Fleming <diane.fleming@rackspace.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Khai Do <zaro0508@gmail.com>
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
This commit is contained in:
Tom Fifield 2013-06-14 14:40:46 +10:00 committed by Jenkins
parent 6caa2f9715
commit 1faf327cfb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jeepyb/cmd/notify_impact.py
View File

@ -60,7 +60,7 @@ def process_impact(git_log, args):
the openstack-manuals launchpad project based on the git_log, then
(and for non-documentation impacts) notify the mailing list of impact
"""
if args.dest_address.lower == 'docimpact':
if args.impact.lower() == 'docimpact':
launchpad = Launchpad.login_with('Gerrit User Sync',
LPNET_SERVICE_ROOT,
GERRIT_CACHE_DIR,