opendev/puppet-ethercalc
Code Issues Proposed changes

Order of the classes parameters is refactored

Browse Source 
Order and intendation of those parameters are changed
to follow Puppet Style Guide recommendation [0].
Moreover, it will allow to an user to find much faster
a variable in a list of variables.

[0]. https://docs.puppetlabs.com/guides/style_guide.html

Change-Id: If012896a95088ae836d5dfa35aa3cad553aee516
This commit is contained in:
Andrey Nikitin 2016-03-21 11:45:51 +03:00
parent 9b833810f5
commit cd6889a359
5 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
manifests/apache.pp
View File

@ -1,15 +1,15 @@
# == Class: etherpad_lite::apache # == Class: etherpad_lite::apache
# #
class etherpad_lite::apache ( class etherpad_lite::apache (
$vhost_name = $::fqdn, $docroot = '/srv/etherpad-lite',
$docroot = '/srv/etherpad-lite', $serveradmin = "webmaster@${::fqdn}",
$serveradmin = "webmaster@${::fqdn}", $ssl_cert_file = '',
$ssl_cert_file = '', $ssl_cert_file_contents = '', # If left empty puppet will not create file.
$ssl_key_file = '', $ssl_chain_file = '',
$ssl_chain_file = '', $ssl_chain_file_contents = '', # If left empty puppet will not create file.
$ssl_cert_file_contents = '', # If left empty puppet will not create file. $ssl_key_file = '',
$ssl_key_file_contents = '', # If left empty puppet will not create file. $ssl_key_file_contents = '', # If left empty puppet will not create file.
$ssl_chain_file_contents = '' # If left empty puppet will not create file. $vhost_name = $::fqdn,
) { ) {
package { 'ssl-cert': package { 'ssl-cert':

4
manifests/buildsource.pp
View File

@ -3,10 +3,10 @@
# define to build from source using ./configure && make && make install. # define to build from source using ./configure && make && make install.
# #
define etherpad_lite::buildsource( define etherpad_lite::buildsource(
$creates = '/nonexistant/file',
$dir = $title, $dir = $title,
$user = 'root',
$timeout = 300, $timeout = 300,
$creates = '/nonexistant/file' $user = 'root',
) { ) {
exec { "./configure in ${dir}": exec { "./configure in ${dir}":

8
manifests/init.pp
View File

@ -12,13 +12,13 @@
# #
# #
class etherpad_lite ( class etherpad_lite (
$ep_user = 'eplite',
$base_log_dir = '/var/log',
$base_install_dir = '/opt/etherpad-lite', $base_install_dir = '/opt/etherpad-lite',
$base_log_dir = '/var/log',
$ep_ensure = 'present',
$ep_user = 'eplite',
$eplite_version = 'develop',
# If set to system will install system package. # If set to system will install system package.
$nodejs_version = 'v0.10.21', $nodejs_version = 'v0.10.21',
$eplite_version = 'develop',
$ep_ensure = 'present',
) { ) {
# where the modules are, needed to easily install modules later # where the modules are, needed to easily install modules later

2
manifests/mysql.pp
View File

@ -1,10 +1,10 @@
# == Class: puppet-etherpad_lite::mysql # == Class: puppet-etherpad_lite::mysql
# #
class etherpad_lite::mysql( class etherpad_lite::mysql(
$database_password,
$mysql_root_password, $mysql_root_password,
$database_name = 'etherpad-lite', $database_name = 'etherpad-lite',
$database_user = 'eplite', $database_user = 'eplite',
$database_password,
) { ) {
class { '::mysql::server': class { '::mysql::server':
root_password => $mysql_root_password, root_password => $mysql_root_password,

8
manifests/site.pp
View File

@ -3,11 +3,11 @@
class etherpad_lite::site ( class etherpad_lite::site (
$database_password, $database_password,
$etherpad_title, $etherpad_title,
$session_key = '', $database_host = 'localhost',
$db_type = 'mysql',
$database_user = 'eplite',
$database_name = 'etherpad-lite', $database_name = 'etherpad-lite',
$database_host = 'localhost' $database_user = 'eplite',
$db_type = 'mysql',
$session_key = '',
) { ) {
include ::etherpad_lite include ::etherpad_lite