Enable arrow alignment lint check

Discussion following https://review.openstack.org/#/c/199792/ confirmed
that we do want to enforce this check. This patch re-enables the check
and fixes lint errors that fail the check.

Change-Id: Id9e8086ba1636d158547a5fc8b2b6d24de511a12

Rakefile

@@ -6,4 +6,3 @@ PuppetLint.configuration.send('disable_80chars')
 PuppetLint.configuration.send('disable_autoloader_layout')
 PuppetLint.configuration.send('disable_class_inherits_from_params_class')
 PuppetLint.configuration.send('disable_class_parameter_defaults')
-PuppetLint.configuration.send('disable_arrow_alignment')

examples/site.pp

@@ -94,24 +94,24 @@ node 'default' {
   }
 
   class { '::askbot':
-    db_provider           => $db_provider,
-    db_name               => $db_name,
-    db_user               => $db_user,
-    db_password           => $db_password,
-    redis_enabled         => $redis_enabled,
-    redis_port            => $redis_port,
-    redis_max_memory      => $redis_max_memory,
-    redis_bind            => $redis_bind,
-    redis_password        => $redis_password,
-    custom_theme_enabled  => false,
-    custom_theme_name     => 'os',
-    site_name             => $site_name,
-    askbot_debug          => true,
-    solr_enabled          => true,
+    db_provider          => $db_provider,
+    db_name              => $db_name,
+    db_user              => $db_user,
+    db_password          => $db_password,
+    redis_enabled        => $redis_enabled,
+    redis_port           => $redis_port,
+    redis_max_memory     => $redis_max_memory,
+    redis_bind           => $redis_bind,
+    redis_password       => $redis_password,
+    custom_theme_enabled => false,
+    custom_theme_name    => 'os',
+    site_name            => $site_name,
+    askbot_debug         => true,
+    solr_enabled         => true,
     # ssl setup
-    site_ssl_enabled      => true,
-    site_ssl_cert_file    => '/etc/ssl/certs/ssl-cert-snakeoil.pem',
-    site_ssl_key_file     => '/etc/ssl/private/ssl-cert-snakeoil.key',
+    site_ssl_enabled     => true,
+    site_ssl_cert_file   => '/etc/ssl/certs/ssl-cert-snakeoil.pem',
+    site_ssl_key_file    => '/etc/ssl/private/ssl-cert-snakeoil.key',
   }
 
   # custom theme

manifests/config.pp

@@ -35,10 +35,10 @@ class askbot::config (
   $smtp_host                    = 'localhost',
 ) {
   file { $site_root:
-    ensure  => directory,
-    owner   => 'root',
-    group   => 'root',
-    mode    => '0755',
+    ensure => directory,
+    owner  => 'root',
+    group  => 'root',
+    mode   => '0755',
   }
 
   file { "${site_root}/upfiles":

manifests/site/setup_template.pp

@@ -12,10 +12,10 @@ define askbot::site::setup_template (
   $dest_dir,
 ) {
   file { "${dest_dir}/${name}":
-    ensure  => present,
-    owner   => 'root',
-    group   => 'root',
-    mode    => '0644',
-    source  => "${template_path}/${name}",
+    ensure => present,
+    owner  => 'root',
+    group  => 'root',
+    mode   => '0644',
+    source => "${template_path}/${name}",
   }
 }