opendev/git-review
Code Issues Proposed changes

Remove useless username parameter from add_remote

Browse Source 
Per review on 3275

Change-Id: Id62de897130cd64b2a83a26f0085618097b7c524
This commit is contained in:
Catrope 2012-01-24 01:46:56 +01:00
parent fc2e03f7aa
commit ca006c3a48
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
git-review
View File

@ -163,12 +163,11 @@ def make_remote_url(username, hostname, port, project):
return "ssh://%s@%s:%s/%s" % (username, hostname, port, project) return "ssh://%s@%s:%s/%s" % (username, hostname, port, project)
def add_remote(username, hostname, port, project): def add_remote(hostname, port, project):
""" Adds a gerrit remote. """ """ Adds a gerrit remote. """
asked_for_username = False asked_for_username = False
if not username: username = os.getenv("USERNAME")
username = os.getenv("USERNAME")
if not username: if not username:
username = run_command('git config --get gitreview.username') username = run_command('git config --get gitreview.username')
if not username: if not username:
@ -328,7 +327,7 @@ def check_remote(branch, remote, hostname, port, project):
# Gerrit remote not present, try to add it # Gerrit remote not present, try to add it
try: try:
add_remote(None, hostname, port, project) add_remote(hostname, port, project)
except: except:
print sys.exc_info()[2] print sys.exc_info()[2]
print "We don't know where your gerrit is. Please manually create " print "We don't know where your gerrit is. Please manually create "