From ca006c3a4838f6ce6d1f5035a37840eb7bc84bf0 Mon Sep 17 00:00:00 2001 From: Catrope Date: Tue, 24 Jan 2012 01:46:56 +0100 Subject: [PATCH] Remove useless username parameter from add_remote Per review on 3275 Change-Id: Id62de897130cd64b2a83a26f0085618097b7c524 --- git-review | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/git-review b/git-review index 411ca6ab..6dc70165 100755 --- a/git-review +++ b/git-review @@ -163,12 +163,11 @@ def make_remote_url(username, hostname, port, project): return "ssh://%s@%s:%s/%s" % (username, hostname, port, project) -def add_remote(username, hostname, port, project): +def add_remote(hostname, port, project): """ Adds a gerrit remote. """ asked_for_username = False - if not username: - username = os.getenv("USERNAME") + username = os.getenv("USERNAME") if not username: username = run_command('git config --get gitreview.username') if not username: @@ -328,7 +327,7 @@ def check_remote(branch, remote, hostname, port, project): # Gerrit remote not present, try to add it try: - add_remote(None, hostname, port, project) + add_remote(hostname, port, project) except: print sys.exc_info()[2] print "We don't know where your gerrit is. Please manually create "