opendev/git-review
Code Issues Proposed changes

Prefer .gitconfig username

Browse Source 
We should check first the .gitconfig username and then the
environment variables. Otherwise, the .gitconfig username is never
used.

Bug: #1223676
Change-Id: I3b7efd53e1e561108b42a471ddcebfd87984922b
This commit is contained in:
Andreas Jaeger 2013-09-11 08:52:20 +02:00
parent 19e8041cdc
commit 7c6c5f3f2d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
git_review/cmd.py
View File

@ -284,9 +284,9 @@ def add_remote(hostname, port, project, remote):
"""Adds a gerrit remote."""
asked_for_username = False
username = os.getenv("USERNAME")
username = git_config_get_value("gitreview", "username")
if not username:
username = git_config_get_value("gitreview", "username")
username = os.getenv("USERNAME")
if not username:
username = os.getenv("USER")
if port is None: