opendev/git-review
Code Issues Proposed changes

Don't fetch remote outside of rebase flow.

Browse Source 
The assert_one_change code checks your changes against the set of changes in
the branch that you're submitting to. It's not necessary to have the absolute
latest changes to do the safety check ... the worst that will happen is that
you'll be prompted about a patch that's already merged.

However, if you run without -R, you'll get the update fetched anyway.

If you run _WITH_ -R, then we're doing a network access that you don't need
anyway.

Change-Id: I466aa81a521f784d9afc1dbae914c68a33ff79f5
This commit is contained in:
Monty Taylor 2013-01-25 11:57:06 +11:00
parent b8f228118e
commit 4898ca5b67
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
git-review
View File

@ -453,7 +453,6 @@ def get_branch_name(target_branch):
def assert_one_change(remote, branch, yes, have_hook):
update_remote(remote)
branch_name = get_branch_name(branch)
has_color = check_color_support()
if has_color: