opendev/git-review
Code Issues Proposed changes

accepts color.ui boolean values

Browse Source 
To configure color, git accepts {auto,never,always} as well as the usual
boolean values {true,false}.

.gitconfig examples:

Always enable colors:
	[color]
		ui = true

Never use colors:
	[color]
		ui = false

Change-Id: I2c309ed8ef1c8b50d0ed283e813dbf64c57d7671
This commit is contained in:
Antoine Musso 2012-01-31 15:20:25 +01:00
parent 62e14dc762
commit 3d6675958f
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS
View File

@ -3,3 +3,4 @@ James E. Blair <james.blair@rackspace.com>
Saggi Mizrahi <smizrahi@redhat.com>
Kiall Mac Innes <kiall@managedit.ie>
Roan Kattouw <roan.kattouw@gmail.com>
Antoine Musso <hashar@free.fr>

6
git-review
View File

@ -388,9 +388,11 @@ def assert_one_change(remote, branch, yes, have_hook):
branch_name = get_branch_name(branch)
has_color = check_color_support()
if has_color:
color = git_config_get_value("color", "ui")
if color == "":
color = git_config_get_value("color", "ui").lower()
if(color == "" or color == "true"):
color = "auto"
elif color == "false":
color = "never"
elif color == "auto":
# Python is not a tty, we have to force colors
color = "always"