opendev/git-restack
Code Issues Proposed changes

Revert "Introduce base exception classes"

Browse Source 
This reverts commit 7486ca41531eba0d4a11eebcd5c3545397146c14
This commit is contained in:
James E. Blair 2012-10-31 16:58:48 +00:00 committed by Gerrit Code Review
parent 7486ca4153
commit 69a5f54991
2 changed files with 2 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
git-review
View File

@ -59,11 +59,7 @@ class colors:
reset = '\033[0m' reset = '\033[0m'
class GitReviewException(Exception): class CommandFailed(Exception):
pass
class CommandFailed(GitReviewException):
def __init__(self, *args): def __init__(self, *args):
Exception.__init__(self, *args) Exception.__init__(self, *args)
@ -82,16 +78,6 @@ The following command failed with exit code %(rc)d
-----------------------""" % self.quickmsg -----------------------""" % self.quickmsg
class ChangeSetException(GitReviewException):
def __init__(self, e):
GitReviewException.__init__(self)
self.e = str(e)
def __str__(self):
return self.__doc__ % self.e
def run_command_status(*argv, **env): def run_command_status(*argv, **env):
if VERBOSE: if VERBOSE:
print(datetime.datetime.now(), "Running:", " ".join(argv)) print(datetime.datetime.now(), "Running:", " ".join(argv))
@ -875,6 +861,6 @@ def main():
if __name__ == "__main__": if __name__ == "__main__":
try: try:
main() main()
except GitReviewException, e: except CommandFailed, e:
print(e) print(e)
sys.exit(e.EXIT_CODE) sys.exit(e.EXIT_CODE)

12
git-review.1
View File

@ -108,18 +108,6 @@ defaultremote=review
defaultrebase=0 defaultrebase=0
.Ed .Ed
.Pp .Pp
.Sh DIAGNOSTICS
.Pp
Normally, exit status is 0 if executed successfully.
Exit status 1 indicates general error, sometimes more
specific error codes are available:
.Bl -tag -width 999
.It 2
Gerrit
.Ar commit-msg
hook could not be successfully installed.
.El
.Pp
.Sh EXAMPLES .Sh EXAMPLES
To fetch a remote change number 3004: To fetch a remote change number 3004:
.Pp .Pp