Several things have bit rotted in here that we need to take care of.
First is that we updated the default nodeset to Noble which breaks our
ability to install Pillow<10 for blockdiag. To fix this we need to
install libjpeg-dev so that we can build a Pillow wheel locally during
testing.
Next old ansible-lint doesn't run on Noble's python3.12. We bump up
Ansible lint to a modern version that matches Zuul's current default
Ansible. We also stop installing zuul to get zuul_console and
zuul_return and instead simply mock them in the linter. To make this
work we have to drop the ansible-playbook syntax check run which is fine
because ansible-lint runs this too, but when done via ansible-lint the
mocked modules are respected [0].
Finally we have to clean up/ignore some of the new linter
warnings/errors.
[0] https://ansible.readthedocs.io/projects/lint/rules/syntax-check/
Change-Id: Ia0e936fefc9e2b0f2fa614c93a2f168e14b2825b
Add a flag that can be set to make this job fail, which can be useful
for intsructing Zuul to hold the node if debugging failures.
Change-Id: I96123c3f585a59958932e9a8cab6aa3b685764d7
Ansible changed, then unchanged their behavior around file modes, but
being explicit is likely a good idea to handle any new future changes
from ansible.
We set modes generously (to 755 for dirs and 644 for files) to avoid
unexpected access problems. Note that depending on the perms in AFS this
may cause a perms ot update on existing dirs but that should be fine as
long as we aren't making them more restrictive.
Finally we skip two cases where modes are required by the linting rule
because they are tarball extraction steps and applying a single mode to
all dirs and files in a tarball doens't make a ton of sense.
Includes bumping linter configuration.
Change-Id: Iacf41549928ba7f05f0f71a79ddef1b6e1154e2a
Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
With change I29ff75d331b433ea4ad3b66ed723eee14a90b404 we no longer
have a proxy. This is causing the buildset registry post playbook
to fail since that container is no longer running.
Change-Id: I71bf04f228a7b3fca62ab84ade376a872a69ee91
Now that we use the buildset-registry job in all docker builds
(whether they run the registry internally or not), in the post
playbook we need to check whether the registry was actually
started in the pre playbook before we attempt to save its logs.
Change-Id: Ifa925faf7bfdc83238677261726aa96461faddb0
This reverts commit f49bf96c320d71b9b966808fdc71abe86c93e045.
This has an error:
The task includes an option with an undefined variable. The error was: 'ansible_user_dir' is undefined
Change-Id: I679499751aec72922ea5063350f446f13579776c
