From fe9ad5c0eabffbd244427a891d8e1ccbc88feb7e Mon Sep 17 00:00:00 2001
From: Monty Taylor <mordred@inaugust.com>
Date: Sun, 10 Jan 2016 12:56:23 -0500
Subject: [PATCH] Collapse redundant hieradata tasks

We can make the task file slightly smaller by using a with_items.

Change-Id: I39f79730b56c40ed2dc0f00a0c354f6e16e12cda
---
 tasks/main.yml | 24 ++++++------------------
 1 file changed, 6 insertions(+), 18 deletions(-)

diff --git a/tasks/main.yml b/tasks/main.yml
index b862a0b..6cbe883 100644
--- a/tasks/main.yml
+++ b/tasks/main.yml
@@ -1,28 +1,16 @@
 ---
 - block:
-  - name: ensure hiera datadir
+  - name: ensure hiera directory
     file:
       state: directory
-      path: "{{ hieradata }}/{{ hieraenvironment }}"
-      owner: root
-      group: root
-      mode: 0700
-
-  - name: ensure hiera datadir - fqdn
-    file:
-      state: directory
-      path: "{{ hieradata }}/{{ hieraenvironment }}/fqdn"
-      owner: root
-      group: root
-      mode: 0700
-
-  - name: ensure hiera datadir - group
-    file:
-      state: directory
-      path: "{{ hieradata }}/{{ hieraenvironment }}/group"
+      path: "{{ hieradata }}/{{ hieraenvironment }}/{{ item }}"
       owner: root
       group: root
       mode: 0700
+    when: copy_hieradata is defined and copy_hieradata
+    with_items:
+    - fqdn
+    - group
 
   - name: make file list
     puppet_get_hiera_file_list: