nebulous/optimiser-controller
Code Issues Proposed changes

Fail gracefully for duplicate performance indicator message

Browse Source 
Change-Id: I5ff7b7236e32a81f8748e527d453eb5a15b2f91c
This commit is contained in:
Rudi Schlatte 2024-04-23 16:34:53 +02:00
parent 8eea253070
commit b5493330b4
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
optimiser-controller/src/main/java/eu/nebulouscloud/optimiser/controller/ExnConnector.java
View File

@ -230,7 +230,7 @@ public class ExnConnector {
Object app_id = message.property("application"); // might be null Object app_id = message.property("application"); // might be null
if (app_id == null) app_id = message.subject(); if (app_id == null) app_id = message.subject();
// if app_id is still null, the filename will look a bit funky but it's not a problem // if app_id is still null, the filename will look a bit funky but it's not a problem
log.info("App creation message received", keyValue("appId", app_id)); log.info("App creation message received, registering app and waiting for performance indicator message", keyValue("appId", app_id));
JsonNode appMessage = mapper.valueToTree(body); JsonNode appMessage = mapper.valueToTree(body);
Main.logFile("app-message-" + app_id + ".json", appMessage.toPrettyString()); Main.logFile("app-message-" + app_id + ".json", appMessage.toPrettyString());
app = NebulousApp.newFromAppMessage( app = NebulousApp.newFromAppMessage(
@ -283,11 +283,16 @@ public class ExnConnector {
NebulousApp app = NebulousApps.get(appId); NebulousApp app = NebulousApps.get(appId);
if (app == null) { if (app == null) {
NebulousApps.relevantPerformanceIndicators.put(appId, appMessage); NebulousApps.relevantPerformanceIndicators.put(appId, appMessage);
log.info("Received performance indicator message for unknown app object, storing", log.info("Received performance indicator message for unregistered app, storing and awaiting app creation message",
keyValue("appId", appId)); keyValue("appId", appId));
} else { } else {
if (app.getState().equals(NebulousApp.State.NEW)) {
app.setStateReady(appMessage); app.setStateReady(appMessage);
app.deployUnmodifiedApplication(); app.deployUnmodifiedApplication();
} else {
log.warn("Received duplicate performance indicator message for app, ignoring",
keyValue("appId", appId));
}
} }
} }
} }