From 3047b7bf6b66d3c915d0e6be06c4126bf55dc050 Mon Sep 17 00:00:00 2001
From: Rudi Schlatte <rudi@ifi.uio.no>
Date: Tue, 21 May 2024 16:53:28 +0200
Subject: [PATCH] Abort deployment if no cloud given in dsl message.

We need at least one cloud id with status `enabled` to deploy.

Change-Id: I1abd2b46f304ffe77c37a29e1656ee62c5e5211c
---
 .../eu/nebulouscloud/optimiser/controller/NebulousApp.java  | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/optimiser-controller/src/main/java/eu/nebulouscloud/optimiser/controller/NebulousApp.java b/optimiser-controller/src/main/java/eu/nebulouscloud/optimiser/controller/NebulousApp.java
index bd680bf..2e42934 100644
--- a/optimiser-controller/src/main/java/eu/nebulouscloud/optimiser/controller/NebulousApp.java
+++ b/optimiser-controller/src/main/java/eu/nebulouscloud/optimiser/controller/NebulousApp.java
@@ -301,9 +301,11 @@ public class NebulousApp {
             .map((c) -> c.get("uuid").asText())
             .collect(Collectors.toSet());
         if (cloudIDs.isEmpty()) {
-            log.warn("No clouds enabled or specified in app creation message, will try to deploy only on edge nodes.");
+            log.error("No enabled clouds given in app creation message, setting app status to FAILED and aborting deployment.");
+            this.setStateFailed();
+        } else {
+            log.debug("New App instantiated.");
         }
-        log.debug("New App instantiated.");
     }
 
     /**