jjb/jenkins-job-builder
Code Issues Proposed changes

publishers: deprecate "evenIfDownstreamUnstable" in join-trigger

Browse Source 
Only emit the joinTrigger evenIfDownstreamUnstable property when
it has been configured.  This property is no longer presented
in newer version of the join plugin, and has been replaced with
a result threshold.  Mark the boolean as deprecated.

Change-Id: If87517330ebbef17146b20f47689a29f8417b20e
Signed-off-by: David Aguilar <davvid@gmail.com>
This commit is contained in:
David Aguilar 2020-06-20 15:21:53 -07:00
parent 52caa12068
commit bc585293b2
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
jenkins_jobs/modules/publishers.py
View File

@ -3493,11 +3493,11 @@ def join_trigger(registry, xml_parent, data):
Trigger a job after all the immediate downstream jobs have completed.
Requires the Jenkins :jenkins-plugins:`Join Plugin <join>`.
:arg bool even-if-unstable: if true jobs will trigger even if some
downstream jobs are marked as unstable (default false)
:arg list projects: list of projects to trigger
:arg list publishers: list of triggers from publishers module that
defines projects that need to be triggered
:arg bool even-if-unstable: if true jobs will trigger even if some
downstream jobs are marked as unstable (default false) (DEPRECATED)
Example:
@ -3515,8 +3515,9 @@ def join_trigger(registry, xml_parent, data):
for edited_node in create_publishers(registry, pub):
publishers.append(edited_node)
unstable = str(data.get("even-if-unstable", "false")).lower()
XML.SubElement(jointrigger, "evenIfDownstreamUnstable").text = unstable
unstable = str(data.get("even-if-unstable", "")).lower()
if unstable:
XML.SubElement(jointrigger, "evenIfDownstreamUnstable").text = unstable
def jabber(registry, xml_parent, data):