Add Private and WIP change support for gerrit

Updated gerrit trigger support to include the new exclude private and
exclude wip changes.

Change-Id: I75d8113941e4e455ec34fab23d347816c2ef699b
This commit is contained in:
Joseph Kostreva 2019-08-22 13:09:36 -05:00 committed by James Harris
parent 8c19ca0cd2
commit 8c29f8931c
5 changed files with 22 additions and 0 deletions

View File

@ -155,6 +155,8 @@ def build_gerrit_triggers(xml_parent, data):
"patchset-uploaded-event": "PluginPatchsetCreatedEvent",
"patchset-created-event": "PluginPatchsetCreatedEvent",
"ref-updated-event": "PluginRefUpdatedEvent",
"private-state-changed-event": "PluginPrivateStateChangedEvent",
"wip-state-changed-event": "PluginWipStateChangedEvent",
}
tag_namespace = (
"com.sonyericsson.hudson.plugins.gerrit.trigger." "hudsontrigger.events"
@ -193,6 +195,8 @@ def build_gerrit_triggers(xml_parent, data):
("exclude-drafts", "excludeDrafts", False),
("exclude-trivial-rebase", "excludeTrivialRebase", False),
("exclude-no-code-change", "excludeNoCodeChange", False),
("exclude-private", "excludePrivateState", False),
("exclude-wip", "excludeWipState", False),
]
helpers.convert_mapping_to_xml(pc, pce, mapping, fail_required=True)
@ -260,7 +264,13 @@ def gerrit(registry, xml_parent, data):
(default false)
* **exclude-no-code-change** (`bool`) -- exclude no code change
(default false)
* **exclude-private** (`bool`) -- exclude private change
(default false)
* **exclude-wip** (`bool`) -- exclude wip change
(default false)
exclude-private|exclude-wip needs
Gerrit Trigger v2.29.0
Exclude drafts|trivial-rebase|no-code-change needs
Gerrit Trigger v2.12.0
@ -276,6 +286,10 @@ def gerrit(registry, xml_parent, data):
Gerrit Trigger Plugin version >= 2.8.0
* **draft-published-event** -- Trigger on draft published event.
* **ref-updated-event** -- Trigger on ref-updated.
Gerrit Trigger Plugin version >= 2.29.0
* **private-state-changed-event** -- Trigger on private state changed event.
* **wip-state-changed-event** -- Trigger on wip state changed event.
Gerrit Trigger Plugin version >= 2.8.0
* **comment-added-event** (`dict`) -- Trigger on comment added.
:Comment added:

View File

@ -54,6 +54,8 @@
<excludeDrafts>true</excludeDrafts>
<excludeTrivialRebase>true</excludeTrivialRebase>
<excludeNoCodeChange>true</excludeNoCodeChange>
<excludePrivateState>true</excludePrivateState>
<excludeWipState>true</excludeWipState>
</com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginPatchsetCreatedEvent>
<com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginCommentAddedEvent>
<verdictCategory>APRV</verdictCategory>

View File

@ -5,6 +5,8 @@ triggers:
exclude-drafts: true
exclude-trivial-rebase: true
exclude-no-code-change: true
exclude-private: true
exclude-wip: true
- comment-added-event:
approval-category: 'APRV'
approval-value: 1

View File

@ -60,6 +60,8 @@
<excludeDrafts>true</excludeDrafts>
<excludeTrivialRebase>true</excludeTrivialRebase>
<excludeNoCodeChange>true</excludeNoCodeChange>
<excludePrivateState>true</excludePrivateState>
<excludeWipState>true</excludeWipState>
</com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginPatchsetCreatedEvent>
<com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginCommentAddedEvent>
<verdictCategory>APRV</verdictCategory>

View File

@ -5,6 +5,8 @@ triggers:
exclude-drafts: true
exclude-trivial-rebase: true
exclude-no-code-change: true
exclude-private: true
exclude-wip: true
- comment-added-event:
approval-category: 'APRV'
approval-value: 1