Fix 'block-level' Build Blocker Plugin Property

In the process of taking advantage of 'convert_mapping_to_xml()',
commit:7ebe78979166e36a038a116788c33383878ced20 renamed 'block-level' to
'blocking-level' in the build-blocker property.

Another unrelated commit modified the test to use 'block_level' instead
of 'block-level'.

Change-Id: I2dd642ec4966c4c48e0a35e986a69b3b74803358
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>

jenkins_jobs/modules/properties.py

@@ -613,7 +613,7 @@ def build_blocker(registry, xml_parent, data):
     mapping = [
         ('use-build-blocker', 'useBuildBlocker', True),
         ('', 'blockingJobs', jobs),
-        ('blocking-level', 'blockLevel', 'GLOBAL', block_level_types),
+        ('block-level', 'blockLevel', 'GLOBAL', block_level_types),
         ('queue-scanning', 'scanQueueFor', 'DISABLED', queue_scan_types),
     ]
     helpers.convert_mapping_to_xml(blocker, data, mapping, fail_required=True)

tests/properties/fixtures/build-blocker-full.xml

@@ -5,7 +5,7 @@
       <useBuildBlocker>true</useBuildBlocker>
       <blockingJobs>.*-deploy
 ^maintenance.*</blockingJobs>
-      <blockLevel>GLOBAL</blockLevel>
+      <blockLevel>NODE</blockLevel>
       <scanQueueFor>BUILDABLE</scanQueueFor>
     </hudson.plugins.buildblocker.BuildBlockerProperty>
   </properties>

tests/properties/fixtures/build-blocker-full.yaml

@@ -4,5 +4,5 @@ properties:
       blocking-jobs:
         - ".*-deploy"
         - "^maintenance.*"
-      block_level: 'GLOBAL'
+      block-level: 'NODE'
       queue-scanning: 'BUILDABLE'