Merge "Add support to reverse trigger for job list"

jenkins_jobs/modules/triggers.py

@@ -890,13 +890,18 @@ def reverse(parser, xml_parent, data):
     "Post-build Actions" of an upstream project, but is preferable when you
     want to configure the downstream project.
 
-    :arg str jobs: List (comma separated) of jobs to watch.
+    :arg str jobs: List of jobs to watch. Can be either a comma separated
+      list or a list.
     :arg str result: Build results to monitor for between the following
       options: success, unstable and failure. (default 'success').
 
     Example:
 
     .. literalinclude:: /../../tests/triggers/fixtures/reverse.yaml
+
+    Example List:
+
+    .. literalinclude:: /../../tests/triggers/fixtures/reverse-list.yaml
     """
     reserveBuildTrigger = XML.SubElement(
         xml_parent, 'jenkins.triggers.ReverseBuildTrigger')
@@ -904,8 +909,12 @@ def reverse(parser, xml_parent, data):
     supported_thresholds = ['SUCCESS', 'UNSTABLE', 'FAILURE']
 
     XML.SubElement(reserveBuildTrigger, 'spec').text = ''
+
+    jobs = data.get('jobs')
+    if isinstance(jobs, list):
+        jobs = ",".join(jobs)
     XML.SubElement(reserveBuildTrigger, 'upstreamProjects').text = \
-        data.get('jobs')
+        jobs
 
     threshold = XML.SubElement(reserveBuildTrigger, 'threshold')
     result = data.get('result').upper()

tests/triggers/fixtures/reverse-list.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>
+<project>
+  <triggers class="vector">
+    <jenkins.triggers.ReverseBuildTrigger>
+      <spec/>
+      <upstreamProjects>a,b,c</upstreamProjects>
+      <threshold>
+        <name>FAILURE</name>
+        <ordinal>2</ordinal>
+        <color>RED</color>
+        <completeBuild>true</completeBuild>
+      </threshold>
+    </jenkins.triggers.ReverseBuildTrigger>
+  </triggers>
+</project>

tests/triggers/fixtures/reverse-list.yaml

@@ -0,0 +1,7 @@
+triggers:
+  - reverse:
+        jobs:
+            - 'a'
+            - 'b'
+            - 'c'
+        result: 'failure'