jjb/jenkins-job-builder
Code Issues Proposed changes

fixed broken active choice reactive param after job creation

Browse Source 
Change-Id: I7e7362a73e9478bdbd445f5178f982afa346f58a
This commit is contained in:
Ruslan Marinin 2021-04-29 20:24:20 +03:00
parent a63f8064a3
commit 15a0896791
3 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
jenkins_jobs/modules/parameters.py
View File

@ -1310,7 +1310,11 @@ def active_choices_reactive_param(registry, xml_parent, data):
__active_choice_param_internal(pdef, data)
mapping = [("referenced-parameters", "referencedParameters", "")]
mapping = [
("referenced-parameters", "referencedParameters", ""),
("random-name", "randomName", "choice-param-{0}".format(data["name"]).lower()),
("visible-items", "visibleItemCount", 1),
]
helpers.convert_mapping_to_xml(pdef, data, mapping, fail_required=False)
XML.SubElement(pdef, "parameters", {"class": "linked-hash-map"})

2
tests/yamlparser/fixtures/active-choices-reactive-param001.xml
View File

@ -29,6 +29,8 @@
<projectName>active-choices-job</projectName>
<projectFullName>active-choices-job</projectFullName>
<referencedParameters/>
<randomName>choice-param-foo</randomName>
<visibleItemCount>1</visibleItemCount>
<parameters class="linked-hash-map"/>
</org.biouno.unochoice.CascadeChoiceParameter>
</parameterDefinitions>

2
tests/yamlparser/fixtures/active-choices-reactive-param002.xml
View File

@ -51,6 +51,8 @@
<projectName>active-choices-job</projectName>
<projectFullName>active-choices-job</projectFullName>
<referencedParameters>foo,bar</referencedParameters>
<randomName>choice-param-lorem</randomName>
<visibleItemCount>1</visibleItemCount>
<parameters class="linked-hash-map"/>
</org.biouno.unochoice.CascadeChoiceParameter>
</parameterDefinitions>