airship/promenade
Code Issues Proposed changes

Fix deprecated warning in Promenade apiserver chart

Browse Source 
Removed PersistentVolumeLabel from apiserver to fix below warning.
Deprecated warning:
1. PersistentVolumeLabel admission controller is deprecated.
   Please remove this controller from your configuration files and scripts.
2. insecure-port has been deprecated, This flag has no effect now
   and will be removed in v1.24.

Change-Id: Iaccff8467b5ed967fa41e85b38c27f7345cd97bb
This commit is contained in:
ubuntu 2021-06-28 18:27:06 +00:00 committed by Thirunavukkarasu Palani
parent 1401664ab2
commit 183b977754
10 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
charts/apiserver-webhook/templates/deployment.yaml
View File

@ -160,7 +160,6 @@ spec:
- --endpoint-reconciler-type=none
- --bind-address=$(POD_IP)
- --secure-port={{ tuple "webhook_apiserver" "podport" "api" $envAll | include "helm-toolkit.endpoints.endpoint_port_lookup" }}
- --insecure-port=0
- --tls-cert-file={{ tuple "apiserver_webhook_pod" "server" $envAll.Values.conf.paths.pki "cert" $envAll | include "local.cert_bundle_path" }}
- --tls-private-key-file={{ tuple "apiserver_webhook_pod" "server" $envAll.Values.conf.paths.pki "key" $envAll | include "local.cert_bundle_path" }}
- --kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname

2
charts/apiserver-webhook/values.yaml
View File

@ -40,7 +40,7 @@ labels:
command_prefix:
- kube-apiserver
- --admission-control=NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,ResourceQuota,DefaultTolerationSeconds
- --admission-control=NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,ResourceQuota,DefaultTolerationSeconds
apiserver_webhook:
logging:

1
charts/apiserver/values.yaml
View File

@ -29,7 +29,6 @@ const:
- --etcd-certfile=/etc/kubernetes/apiserver/pki/etcd-client.pem
- --etcd-keyfile=/etc/kubernetes/apiserver/pki/etcd-client-key.pem
- --etcd-servers=$(ETCD_ENDPOINTS)
- --insecure-port=0
- --kubelet-certificate-authority=/etc/kubernetes/apiserver/pki/cluster-ca.pem
- --kubelet-client-certificate=/etc/kubernetes/apiserver/pki/kubelet-client.pem
- --kubelet-client-key=/etc/kubernetes/apiserver/pki/kubelet-client-key.pem

2
examples/containerd/Genesis.yaml
View File

@ -21,7 +21,7 @@ data:
apiserver:
arguments:
- --authorization-mode=Node,RBAC
- --enable-admission-plugins=NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,ResourceQuota,DefaultTolerationSeconds,EventRateLimit,PersistentVolumeLabel,DefaultStorageClass,ResourceQuota
- --enable-admission-plugins=NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,ResourceQuota,DefaultTolerationSeconds,EventRateLimit,DefaultStorageClass,ResourceQuota
- --service-cluster-ip-range=10.96.0.0/16
- --endpoint-reconciler-type=lease
- --admission-control-config-file=/etc/kubernetes/apiserver/acconfig.yaml

2
examples/gate/Genesis.yaml
View File

@ -21,7 +21,7 @@ data:
apiserver:
arguments:
- --authorization-mode=Node,RBAC
- --enable-admission-plugins=NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,ResourceQuota,DefaultTolerationSeconds,EventRateLimit,PersistentVolumeLabel,DefaultStorageClass,ResourceQuota
- --enable-admission-plugins=NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,ResourceQuota,DefaultTolerationSeconds,EventRateLimit,DefaultStorageClass,ResourceQuota
- --service-cluster-ip-range=10.96.0.0/16
- --endpoint-reconciler-type=lease
- --admission-control-config-file=/etc/kubernetes/apiserver/acconfig.yaml

1
promenade/templates/roles/genesis/etc/kubernetes/manifests/bootstrap-armada.yaml
View File

@ -156,7 +156,6 @@ spec:
{%- endfor %}
{% include "genesis-apiserver.yaml" with context %}
- --etcd-servers=https://localhost:12379
- --insecure-port=0
- --secure-port=6444
- --endpoint-reconciler-type=none
env:

1
promenade/templates/roles/genesis/etc/kubernetes/manifests/kubernetes-apiserver.yaml
View File

@ -21,7 +21,6 @@ spec:
{%- endfor %}
{% include "genesis-apiserver.yaml" with context %}
- --etcd-servers=https://localhost:2379
- --insecure-port=0
- --secure-port=6443
volumeMounts:
- name: config

2
tests/unit/api/test_validatedesign.py
View File

@ -82,7 +82,7 @@ VALID_DOCS = [
'apiserver': {
'command_prefix': [
'/apiserver', '--authorization-mode=Node,RBAC',
'--admission-control=NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,ResourceQuota,DefaultTolerationSeconds',
'--admission-control=NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,ResourceQuota,DefaultTolerationSeconds',
'--service-cluster-ip-range=10.96.0.0/16',
'--endpoint-reconciler-type=lease'
]

2
tests/unit/builder_data/simple/Genesis.yaml
View File

@ -14,7 +14,7 @@ data:
command_prefix:
- /apiserver
- --authorization-mode=Node,RBAC
- --admission-control=NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,ResourceQuota,DefaultTolerationSeconds
- --admission-control=NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,ResourceQuota,DefaultTolerationSeconds
- --service-cluster-ip-range=10.96.0.0/16
- --endpoint-reconciler-type=lease
armada:

2
tests/unit/builder_data/simple/armada-resources.yaml
View File

@ -628,7 +628,7 @@ data:
command_prefix:
- /apiserver
- --authorization-mode=Node,RBAC
- --admission-control=NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,ResourceQuota,DefaultTolerationSeconds
- --admission-control=NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,ResourceQuota,DefaultTolerationSeconds
- --service-cluster-ip-range=10.96.0.0/16
- --endpoint-reconciler-type=lease
apiserver: