b2af034e57
This implementation creates named references between an airship
config file , and a user specified or system default kubeconfig file
airshipconfig location can be specified via an envirnment variable
or via
--airshipconf string Path to file for airshipctl configuration.
(default ".airship/config")
kubeconfig has to be explicitly stated using the argument below
--kubeconfig string Path to kubeconfig associated with airshipctl
configuration. (default ".airship/kubeconfig")
if the argument is not specified a default empty kubeconfig will be
used using the default ".airship/kubeconfig"
All subcommands exposed via airshipctl config will update airship
config and airship related kubeconfig
when appropriate.
This patchset adds :
- Config Struct (type)
- config cmd and pkg
- get_cluster : List a specific name cluster or
List all clusters if no name is provided.
- set-cluster : Create or Modify an existing cluster.
Review comment fixes as of Pathset 19
- Moved core functionality from cmd to pkg
- Encapsulate cmd needs in pck in nw files cmds, cmds_types and cmds_test .
Expectation is that other functions will need func an structs there.
- added test for GetCluster
- Added GetCluster method to config object to be used by get_cluster command
- Change ClusterNames func as per review suggestion
- Change TestEmpty Cluster to avoid pointing to non test kubecnfig by default
- Change constant AirshipConfigFilePath to AirshipConfigDir
- Renamed config_utils to utils
- Added config cmd output tests
- Changes to settings_test.go to clean after itself.
- Created new pkg/config/testdata/GoldenString for struct data comparison values to avoid confusion
- Fix small get_cluster no name issue when empty config
- Fix issue when reconciling a cluster info that only exists in airship config and not in kubeconfig
Increased coverage to: SUCCESS: Test coverage is at 84.2%,
Started to move all testdata to a single place under pkg/config for now.
Change-Id: I7aae1f15afaebc99407f7fabccecf86ab0923bc3
137 lines
3.2 KiB
Go
137 lines
3.2 KiB
Go
/*
|
|
Copyright 2014 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package environment
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/spf13/cobra"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"opendev.org/airship/airshipctl/pkg/config"
|
|
)
|
|
|
|
const (
|
|
testDataDir = "../../pkg/config/testdata"
|
|
testMimeType = ".yaml"
|
|
)
|
|
|
|
// Bogus for coverage
|
|
func FakeCmd() *cobra.Command {
|
|
fakecmd := &cobra.Command{
|
|
Use: "fakecmd",
|
|
Run: func(cmd *cobra.Command, args []string) {},
|
|
}
|
|
return fakecmd
|
|
}
|
|
|
|
func TestInitFlags(t *testing.T) {
|
|
|
|
// Get the Environment
|
|
settings := &AirshipCTLSettings{}
|
|
fakecmd := FakeCmd()
|
|
settings.InitFlags(fakecmd)
|
|
assert.True(t, fakecmd.HasPersistentFlags())
|
|
|
|
}
|
|
|
|
func TestNewConfig(t *testing.T) {
|
|
// Initialize kubeconfig
|
|
src := filepath.Join(testDataDir, config.AirshipKubeConfig+testMimeType)
|
|
dst := filepath.Join(config.AirshipConfigDir, config.AirshipKubeConfig)
|
|
err := initTestDir(config.AirshipConfigDir)
|
|
require.NoError(t, err)
|
|
|
|
defer clean(config.AirshipConfigDir)
|
|
_, err = copy(src, dst)
|
|
require.NoError(t, err)
|
|
|
|
settings := &AirshipCTLSettings{}
|
|
settings.InitConfig()
|
|
conf := settings.Config()
|
|
assert.NotNil(t, conf)
|
|
|
|
}
|
|
|
|
func TestSpecifyAirConfigFromEnv(t *testing.T) {
|
|
fakeConfig := "FakeConfigPath"
|
|
err := os.Setenv(config.AirshipConfigEnv, fakeConfig)
|
|
require.NoError(t, err)
|
|
|
|
settings := &AirshipCTLSettings{}
|
|
settings.InitConfig()
|
|
|
|
assert.EqualValues(t, fakeConfig, settings.AirshipConfigPath())
|
|
}
|
|
func TestGetSetPaths(t *testing.T) {
|
|
settings := &AirshipCTLSettings{}
|
|
settings.InitConfig()
|
|
airConfigFile := filepath.Join(config.AirshipConfigDir, config.AirshipConfig)
|
|
kConfigFile := filepath.Join(config.AirshipConfigDir, config.AirshipKubeConfig)
|
|
settings.SetAirshipConfigPath(airConfigFile)
|
|
assert.EqualValues(t, airConfigFile, settings.AirshipConfigPath())
|
|
|
|
settings.SetKubeConfigPath(kConfigFile)
|
|
assert.EqualValues(t, kConfigFile, settings.KubeConfigPath())
|
|
}
|
|
|
|
func TestSpecifyKubeConfigInCli(t *testing.T) {
|
|
fakecmd := FakeCmd()
|
|
|
|
settings := &AirshipCTLSettings{}
|
|
settings.InitFlags(fakecmd)
|
|
assert.True(t, fakecmd.HasPersistentFlags())
|
|
}
|
|
|
|
func initTestDir(dst string) error {
|
|
return os.MkdirAll(dst, 0755)
|
|
}
|
|
|
|
func copy(src, dst string) (int64, error) {
|
|
sourceFileStat, err := os.Stat(src)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
|
|
if !sourceFileStat.Mode().IsRegular() {
|
|
return 0, fmt.Errorf("%s is not a regular file", src)
|
|
}
|
|
|
|
source, err := os.Open(src)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
defer source.Close()
|
|
|
|
destination, err := os.Create(dst)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
defer destination.Close()
|
|
nBytes, err := io.Copy(destination, source)
|
|
return nBytes, err
|
|
}
|
|
|
|
func clean(dst string) error {
|
|
return os.RemoveAll(dst)
|
|
}
|