b2af034e57
This implementation creates named references between an airship
config file , and a user specified or system default kubeconfig file
airshipconfig location can be specified via an envirnment variable
or via
--airshipconf string Path to file for airshipctl configuration.
(default ".airship/config")
kubeconfig has to be explicitly stated using the argument below
--kubeconfig string Path to kubeconfig associated with airshipctl
configuration. (default ".airship/kubeconfig")
if the argument is not specified a default empty kubeconfig will be
used using the default ".airship/kubeconfig"
All subcommands exposed via airshipctl config will update airship
config and airship related kubeconfig
when appropriate.
This patchset adds :
- Config Struct (type)
- config cmd and pkg
- get_cluster : List a specific name cluster or
List all clusters if no name is provided.
- set-cluster : Create or Modify an existing cluster.
Review comment fixes as of Pathset 19
- Moved core functionality from cmd to pkg
- Encapsulate cmd needs in pck in nw files cmds, cmds_types and cmds_test .
Expectation is that other functions will need func an structs there.
- added test for GetCluster
- Added GetCluster method to config object to be used by get_cluster command
- Change ClusterNames func as per review suggestion
- Change TestEmpty Cluster to avoid pointing to non test kubecnfig by default
- Change constant AirshipConfigFilePath to AirshipConfigDir
- Renamed config_utils to utils
- Added config cmd output tests
- Changes to settings_test.go to clean after itself.
- Created new pkg/config/testdata/GoldenString for struct data comparison values to avoid confusion
- Fix small get_cluster no name issue when empty config
- Fix issue when reconciling a cluster info that only exists in airship config and not in kubeconfig
Increased coverage to: SUCCESS: Test coverage is at 84.2%,
Started to move all testdata to a single place under pkg/config for now.
Change-Id: I7aae1f15afaebc99407f7fabccecf86ab0923bc3
108 lines
2.6 KiB
Go
108 lines
2.6 KiB
Go
/*
|
|
Copyright 2014 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package config
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"opendev.org/airship/airshipctl/pkg/config"
|
|
"opendev.org/airship/airshipctl/pkg/environment"
|
|
)
|
|
|
|
type getClusterTest struct {
|
|
config *config.Config
|
|
args []string
|
|
flags []string
|
|
expected string
|
|
}
|
|
|
|
const (
|
|
testMimeType = ".yaml"
|
|
testDataDir = "../../pkg/config/testdata"
|
|
)
|
|
|
|
func TestGetCluster(t *testing.T) {
|
|
tname := "def"
|
|
tctype := config.Ephemeral
|
|
|
|
conf := config.InitConfig(t)
|
|
|
|
// Retrieve one of the test
|
|
theClusterIWant, err := conf.GetCluster(tname, tctype)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, theClusterIWant)
|
|
|
|
err = conf.Purge()
|
|
require.NoErrorf(t, err, "unexpected error , unable to Purge before persisting the expected configuration: %v", err)
|
|
err = conf.PersistConfig()
|
|
require.NoErrorf(t, err, "unexpected error , unable to Persist the expected configuration: %v", err)
|
|
|
|
test := getClusterTest{
|
|
config: conf,
|
|
args: []string{tname},
|
|
flags: []string{
|
|
"--" + config.FlagClusterType + "=" + config.Ephemeral,
|
|
},
|
|
expected: theClusterIWant.PrettyString(),
|
|
}
|
|
|
|
test.run(t)
|
|
}
|
|
|
|
func TestGetAllClusters(t *testing.T) {
|
|
conf := config.InitConfig(t)
|
|
|
|
expected := ""
|
|
clusters, err := conf.GetClusters()
|
|
require.NoError(t, err)
|
|
for _, cluster := range clusters {
|
|
expected += fmt.Sprintf("%s", cluster.PrettyString())
|
|
}
|
|
|
|
test := getClusterTest{
|
|
config: conf,
|
|
args: []string{},
|
|
flags: []string{},
|
|
expected: expected,
|
|
}
|
|
|
|
test.run(t)
|
|
}
|
|
|
|
func (test getClusterTest) run(t *testing.T) {
|
|
// Get the Environment
|
|
settings := &environment.AirshipCTLSettings{}
|
|
settings.SetConfig(test.config)
|
|
buf := bytes.NewBuffer([]byte{})
|
|
cmd := NewCmdConfigGetCluster(settings)
|
|
cmd.SetOutput(buf)
|
|
cmd.SetArgs(test.args)
|
|
err := cmd.Flags().Parse(test.flags)
|
|
require.NoErrorf(t, err, "unexpected error flags args to command: %v, flags: %v", err, test.flags)
|
|
|
|
err = cmd.Execute()
|
|
assert.NoErrorf(t, err, "unexpected error executing command: %v", err)
|
|
if len(test.expected) != 0 {
|
|
assert.EqualValues(t, test.expected, buf.String())
|
|
}
|
|
}
|